Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b7pre) Gecko/20101003 Firefox/4.0b7pre (manually downloaded and installed) 1. Download http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2010-10-02-04-mozilla-central/firefox-4.0b7pre.en-US.win32.zip 2. Extract it into a new directory, run firefox.exe with a new profile. 3. Minefield button -> Help -> About Minefield, press Apply Update when the download completes. Actual Results: Firefox fails to update and restart. With Task Manager open, I don't see updater.exe appear, although I could be missing it. Relaunching Firefox triggers the partial update failure dialog, downloading the full update and pressing the Restart button results in the same thing (Firefox closes but doesn't update and then start up). Expected Results: "Minefield Update" appears after Firefox closes, update applies and updated Firefox launches.

Confirming on 32bit Windows too, looking at mozillazin forum there are other users with the same problem, so it doesn't seem to be just a isolated conflict.

Error Message: "The Update could not be installed (patch apply failed)". App Update Log tells: AUS:SVC UpdateService:_postUpdateProcessing - install of complete or only one patch offered failed... showing error. ---------- AUS:UI gUpdates:onLoad - setting current page to startpage errors ---------- AUS:UI gErrorsPage:onPageShow - update.statusText: The Update could not be installed (patch apply failed)

I never see a UAC prompt for either the partial or complete update, and the browser does not relaunch itself. It appears as if the updater is never launched or exits immediately.

Confirm the same problem for Shredder, Mozilla/5.0 (Windows NT 5.1; rv:2.0b7pre) Gecko/20101002 Thunderbird/3.3a1pre Build ID: 20101002033350, Application Changeset ID: 51fbb624b47a, Platform Changeset ID: 286d3026ae20

I think that at least understanding what has happened with this particular build blocks.

Obvious candidate for the regression: http://hg.mozilla.org/mozilla-central/pushloghtml?changeset=861afa477aba

Used these instructions: https://developer.mozilla.org/index.php?title=en/How_to_get_a_stacktrace_with_WinDbg

Updater.exe appears in Process Explorer, but it terminates immediately.

Comment on attachment 480520 [details] [diff] [review] patch rev1 Looks fine to me. I also verified that the other changes from bug 600777 are fine, and Rob said he was able to successfully apply an update with an updater containing this fix.

Pushed http://hg.mozilla.org/mozilla-central/rev/7593c4baa1f7

Also, filed bug 601515 to fix the C-cast that hid this problem in the compile, and bug 601518 for having tests to cover launching the updater from the app.

Just verified that updates are working again on Windows with the latest hourly

Well, updating is still failing.

If you get a patch apply failed you will need to download / install the latest nightly build from. The build you are using has a bug (specifically Bug 601469) that breaks the updater http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-trunk/

I'm running Shredder nightly on old Dell D820 32bit XP SP3. Mozilla/5.0 (Windows NT 5.1; rv:2.0b7pre) Gecko/20101002 Thunderbird/3.3a1pre The nightly build fails to install for me too: After hitting install-now/restart button, Shredder never restarts. (no lingering processes that I can spot in the process table) When I restart by hand I get the following dialog box: Update Failed there were problems checking for, downloading, or installing this update. Shredder could not be updated because: The update could not be installed (patch apply failed). Per the note above, I will go and find the nightly build and install it.

Verified fixed on Win7 by upgrading to the most recent nightly build: Mozilla/5.0 (Windows NT 6.1; rv:2.0b8pre) Gecko/20101007 Firefox/4.0b8pre

Test added in bug 601518