Closed
Bug 602024
Opened 14 years ago
Closed 14 years ago
mixed licensing in HUDService.jsm is confusing
Categories
(DevTools :: General, defect, P3)
DevTools
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Gavin, Assigned: msucan)
References
Details
(Whiteboard: [patchclean:1201])
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
HUDService includes a block of code copied from Firebug, used under different license terms as the rest of the file.
Rather than surrounding it with comments, we should just put it into it's own file (either via a preprocessor #include, or even better as a self-contained JS module), like we did with stylePanel.jsm for inspector.
|
||
Comment 1•14 years ago
|
||
(In reply to comment #0)
> or even better as a self-contained JS
> module), like we did with stylePanel.jsm for inspector.
Agreed. Separate file is best, as we do not want to hunt for the correct line number on errors.
|
||
Updated•14 years ago
|
Blocks: devtools4b8
|
|
||
Updated•14 years ago
|
Assignee: nobody → mihai.sucan
|
Reporter | |
Comment 2•14 years ago
|
||
After we do this we'd need to update the comment in http://hg.mozilla.org/mozilla-central/rev/17f25ba7a1f3 as well, I believe.
|
Assignee | |
Comment 3•14 years ago
|
||
Proposed patch.
This patch moves the firebug code into a new NetworkHelper.jsm. No regressions, during testing. I also updated the toolkit/content/license.html as was suggested in the comment above.
Attachment #484395 -
Flags: feedback?(rcampbell)
|
|
Assignee | |
Updated•14 years ago
|
Status: NEW → ASSIGNED
Whiteboard: [patchclean:1019]
|
|
Reporter | |
Updated•14 years ago
|
Attachment #484395 -
Flags: review+
Attachment #484395 -
Flags: approval2.0+
|
||
Updated•14 years ago
|
Attachment #484395 -
Flags: feedback?(rcampbell) → feedback+
|
|
Assignee | |
Comment 5•14 years ago
|
||
Rebased the patch.
Thanks for the f+, r+ and a+!
Attachment #484395 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [patchclean:1019] → [patchclean:1201][checkin]
|
|
||
Comment 6•14 years ago
|
||
Comment on attachment 494467 [details] [diff] [review]
[checked-in] rebased patch
http://hg.mozilla.org/mozilla-central/rev/b92216d0aea9
Attachment #494467 -
Attachment description: rebased patch → [checked-in] rebased patch
|
|
||
Updated•14 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [patchclean:1201][checkin] → [patchclean:1201]
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•