Closed Bug 602199 Opened 14 years ago Closed 14 years ago

Eliminate cached console data when moving in and out of Private Browsing

Categories

(DevTools :: General, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 612658

People

(Reporter: dangoor, Assigned: ddahl)

References

Details

(Keywords: privacy)

Attachments

(1 file, 1 obsolete file)

Comments from dveditz during the security review of the Web Console: currently not caching data, but when we are it should be purged when going into/out of Private Browsing mode. There may not be an issue in practice, but we definitely need to see what the behavior is and confirm that it is as expected.
The Error Console (and console service) are cleared on enter/exit private browsing, the same should be done here (aiui the Web Console will be caching its messages).
blocking2.0: --- → ?
Keywords: privacy
OS: Mac OS X → All
Hardware: x86 → All
Version: unspecified → Trunk
Assignee: nobody → rcampbell
Assignee: rcampbell → nobody
Depends on: 601260
Now that the lazy console has landed, it makes sense to do this one. Assigning to self just so it's not lost (Mihai, feel free to take if you'd like).
Assignee: nobody → pwalton
I hadn't worried about assigning this one yet, because there's no cache to clear yet (there are other bugs for that like bug 601260 on which this one depends.)
This patch will be something like: XPCOMUtils.defineLazyServiceGetter(this, "gConsoleStorage", "@mozilla.org/console-storage-service;1", "nsIConsoleStorageService"); // in an observer for "private browsing exit" (or whatever it is called) gConsoleStorage.deleteStorage() Although, now that I look at the IDL, it seems like we need a resetStorage() method that deletes the storage data and re-initializes it with an empty array.
Depends on: 613512
mass change: filter on PRIORITYSETTING
Priority: -- → P1
mass change: filter on PRIORITYSETTING
Blocks: devtools4
It would probably be best to have the ConsoleStorageService handle this itself...
Assignee: pwalton → ddahl
(In reply to comment #7) > It would probably be best to have the ConsoleStorageService handle this > itself... as per this comment - talking this bug and the patch with be part of the initial ConsoleStorageService bug 612658 (the test is larger than the changes required)
Attached patch WIP, failing test (obsolete) (deleted) — Splinter Review
saving work
Attached patch v 0.1 Tests included (deleted) — Splinter Review
This patch requires the patches from bug 612658 and bug 609890
Attachment #494285 - Attachment is obsolete: true
Attachment #494506 - Flags: review?(gavin.sharp)
This bug should block as it has to do with privacy.
blocking2.0: ? → ---
Whiteboard: will be fixed by bug 612658
Whiteboard: will be fixed by bug 612658 → will be fixed by bug 612658, DUPEME?
Attachment #494506 - Flags: review?(gavin.sharp)
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → DUPLICATE
Whiteboard: will be fixed by bug 612658, DUPEME?
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: