Closed
Bug 602245
Opened 14 years ago
Closed 14 years ago
PGO builds fail with --enable-tests where SIMPLE_PROGRAMS are linked against objects compiled with -fprofile-generate
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla6
People
(Reporter: chrisccoulson, Assigned: glandium)
References
Details
Attachments
(2 files, 1 obsolete file)
|
(deleted),
text/plain
|
Details | |
|
(deleted),
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
I tried doing a profiledbuild with latest mozilla-central. I get a build failure when trying to link nsIFileEnumerator (I've attached the error).
The issue seems to be that the objects in libxpcomglue_s are compiled with -fprofile-generate, but the linking is done without (as a side-effect of bug 542504).
The GCC manual states "You must use ‘-fprofile-generate’ both when compiling and when linking your program."
|
Reporter | |
Updated•14 years ago
|
Attachment #481263 -
Attachment mime type: application/octet-stream → text/plain
|
|
Reporter | |
Comment 1•14 years ago
|
||
Urgh, and, of course - I meant to say "--enable-tests" ;)
|
||
Comment 2•14 years ago
|
||
I guess we should fix it the way I said in bug 542504 comment 3 instead. :-/
|
Assignee | |
Updated•14 years ago
|
Summary: PGO builds fail with --disable-tests where SIMPLE_PROGRAMS are linked against objects compiled with -fprofile-generate → PGO builds fail with --enable-tests where SIMPLE_PROGRAMS are linked against objects compiled with -fprofile-generate
|
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → mh+mozilla
|
|
Assignee | |
Comment 4•14 years ago
|
||
Attachment #521477 -
Flags: review?(ted.mielczarek)
|
|
Assignee | |
Comment 5•14 years ago
|
||
The previous iteration led to a failure to build on windows due to xpcom/tests/windows/Makefile.in including config.mk before setting CPP_UNIT_TESTS.
Attachment #521477 -
Attachment is obsolete: true
Attachment #521543 -
Flags: review?(ted.mielczarek)
Attachment #521477 -
Flags: review?(ted.mielczarek)
|
|
||
Updated•14 years ago
|
Attachment #521543 -
Flags: review?(ted.mielczarek) → review+
|
|
Assignee | |
Comment 6•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•