Closed Bug 602907 Opened 14 years ago Closed 14 years ago

Mac release repackaging breaks with release file names

Categories

(SeaMonkey :: Build Config, defect)

x86
macOS
defect
Not set
normal

Tracking

(blocking-seamonkey2.1 b1+)

RESOLVED FIXED
seamonkey2.1b1
Tracking Status
blocking-seamonkey2.1 --- b1+

People

(Reporter: kairo, Assigned: kairo)

References

Details

Attachments

(1 file)

Due to a subtle change in bug 586848, we now break in Mac release L10n repacks due to the spaces in the file names, as we now double-quote a target name and that doesn't work out well. See this error message from the 2.1b1 runs: mv -f "../../mozilla/dist/l10n-stage/mac/ru/SeaMonkey 2.1 Beta 1.dmg" ""/builds/slave/macosx_repack/build/comm-central/suite/locales/../../mozilla/dist/mac/ru/SeaMonkey 2.1 Beta 1.dmg"" usage: mv [-f | -i | -n] [-v] source target mv [-f | -i | -n] [-v] source ... directory make[1]: *** [repackage-zip] Error 64 The problem comes down to the ZIP_OUT var after http://hg.mozilla.org/comm-central/diff/e58c1b036d73/suite/locales/Makefile.in being different in quoting to the ZIP_OUT var after http://hg.mozilla.org/mozilla-central/diff/7cf1fba2029a/toolkit/locales/l10n.mk and due to us using that value in another set of quotes in the mv command, we fail. Linux (tar.bz2) and Windows (.zip) don't have spaces in their file names, so they dodge this, and apparently the different setting of the Windows .exe ZIP_OUT doesn't pose a problem as well, so actually, it turns out to fail on Mac only. Removing the quotes on ZIP_OUT should do it.
blocking-seamonkey2.1: --- → b1+
Attached patch Fix the quotes (deleted) — Splinter Review
Here's what should fix this, I'll take reviews from the first of you who comes around to it, as we really should see to getting working Beta 1 builds going.
Attachment #481873 - Flags: review?(neil)
Attachment #481873 - Flags: review?(bugspam.Callek)
Attachment #481873 - Flags: review?(neil) → review+
Attachment #481873 - Flags: review?(bugspam.Callek)
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: