Closed
Bug 603005
Opened 14 years ago
Closed 14 years ago
HUDService should avoid the use of DOM mutation event listeners
Categories
(DevTools :: General, defect, P1)
DevTools
General
Tracking
(blocking2.0 betaN+)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
blocking2.0 | --- | betaN+ |
People
(Reporter: Gavin, Assigned: pcwalton)
References
Details
(Keywords: perf)
The HUDService adds a DOMNodeInserted handler to the outputNode to detect messages being added to check whether they need to be filtered. That makes all DOM mutations on the chrome document slower than they need to be. It should do the filtering before the element is added to the output node (I realize there may be multiple callers...) rather than relying on a DOM mutation event.
Assignee | ||
Comment 1•14 years ago
|
||
(In reply to comment #0)
> The HUDService adds a DOMNodeInserted handler to the outputNode to detect
> messages being added to check whether they need to be filtered. That makes all
> DOM mutations on the chrome document slower than they need to be. It should do
> the filtering before the element is added to the output node (I realize there
> may be multiple callers...) rather than relying on a DOM mutation event.
This will be easier to do after the console styling output patch is done. One of the side effects of this patch is that all messages will be routed through a common output function.
Alternately, we could fix up and land bug 578658.
Updated•14 years ago
|
Assignee: nobody → pwalton
Blocks: devtools4b8
Assignee | ||
Comment 2•14 years ago
|
||
This is fixed in my patch queue for bug 605621.
Status: NEW → ASSIGNED
Updated•14 years ago
|
blocking2.0: ? → betaN+
Assignee | ||
Comment 3•14 years ago
|
||
Fixed in the patch attached to bug 605621.
Comment 6•14 years ago
|
||
Kevin: You're abusing the bug severity field. It's not supposed to mirror the release-blocking state.
Severity: blocker → normal
Comment 7•14 years ago
|
||
Dao: sorry about that. I didn't realize that people were relying on that field for other metrics and such.
Comment 8•14 years ago
|
||
fixed by landing of patch in bug 605621
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•