Closed Bug 603005 Opened 14 years ago Closed 14 years ago

HUDService should avoid the use of DOM mutation event listeners

Categories

(DevTools :: General, defect, P1)

defect

Tracking

(blocking2.0 betaN+)

RESOLVED FIXED
Tracking Status
blocking2.0 --- betaN+

People

(Reporter: Gavin, Assigned: pcwalton)

References

Details

(Keywords: perf)

The HUDService adds a DOMNodeInserted handler to the outputNode to detect messages being added to check whether they need to be filtered. That makes all DOM mutations on the chrome document slower than they need to be. It should do the filtering before the element is added to the output node (I realize there may be multiple callers...) rather than relying on a DOM mutation event.
(In reply to comment #0) > The HUDService adds a DOMNodeInserted handler to the outputNode to detect > messages being added to check whether they need to be filtered. That makes all > DOM mutations on the chrome document slower than they need to be. It should do > the filtering before the element is added to the output node (I realize there > may be multiple callers...) rather than relying on a DOM mutation event. This will be easier to do after the console styling output patch is done. One of the side effects of this patch is that all messages will be routed through a common output function. Alternately, we could fix up and land bug 578658.
Assignee: nobody → pwalton
Blocks: devtools4b8
blocking2.0: --- → ?
Keywords: perf
This is fixed in my patch queue for bug 605621.
Status: NEW → ASSIGNED
blocking2.0: ? → betaN+
Depends on: 605621
Fixed in the patch attached to bug 605621.
mass change: filter on PRIORITYSETTING
Blocks: devtools4
Priority: -- → P1
mass change: filter mail on BLOCKERSETTING
Severity: normal → blocker
Kevin: You're abusing the bug severity field. It's not supposed to mirror the release-blocking state.
Severity: blocker → normal
Dao: sorry about that. I didn't realize that people were relying on that field for other metrics and such.
fixed by landing of patch in bug 605621
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.