Closed
Bug 603210
Opened 14 years ago
Closed 14 years ago
Fix test: browser_webconsole_bug_580030_errors_after_page_reload.js
Categories
(DevTools :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ddahl, Assigned: msucan)
References
Details
(Whiteboard: [patchclean:1018])
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
Details | Diff | Splinter Review |
This test asserts and/or fails too often - needs a refactor. Have had to remove it from the webconsole suite.
Updated•14 years ago
|
Assignee: nobody → mihai.sucan
Blocks: devtools4b8
Assignee | ||
Comment 1•14 years ago
|
||
Proposed test fix. Changes:
- the DOMContentLoaded event is fired before load, and we are trying to reload the page before it completes the first load. Changed the code to use only the load event.
- use executeSoon() in the onLoad event handler because we do not want to ask for reloading while the browser still executes the onload event handlers. We push the reload() call a bit later this way.
- we use a synthetic MouseEvent that is not wrapped by xpcom, to workaround a bug in Gecko that prevents the logging of exceptions thrown in event handlers executed by synthetic events.
- removed the output error line check, because that depends on UI localization and was unneeded. I don't know when this check was added. Afaik, it wasn't in the initial test I submitted.
The test now runs fine in opt and debug builds.
Attachment #482822 -
Flags: feedback?(ddahl)
Assignee | ||
Updated•14 years ago
|
Status: NEW → ASSIGNED
Whiteboard: [patchclean:1013]
Reporter | ||
Updated•14 years ago
|
Attachment #482822 -
Flags: feedback?(ddahl) → feedback+
Assignee | ||
Comment 2•14 years ago
|
||
Comment on attachment 482822 [details] [diff] [review]
proposed test fix
Thanks David for the feedback+! Asking for review now.
Attachment #482822 -
Flags: review?(dietrich)
Assignee | ||
Comment 3•14 years ago
|
||
Comment on attachment 482822 [details] [diff] [review]
proposed test fix
Canceling review request - this only a test fix, and it seems reviews are not needed for such changes.
Attachment #482822 -
Flags: review?(dietrich)
Assignee | ||
Comment 4•14 years ago
|
||
Adding checkin-needed, given it's only a test change.
Keywords: checkin-needed
Assignee | ||
Comment 5•14 years ago
|
||
Fix for compartments landing.
Attachment #482822 -
Attachment is obsolete: true
Assignee | ||
Updated•14 years ago
|
Whiteboard: [patchclean:1013] → [patchclean:1018]
Comment 6•14 years ago
|
||
Comment on attachment 484019 [details] [diff] [review]
[checked-in] rebased patch (fix for compartments)
http://hg.mozilla.org/mozilla-central/rev/e695ac53ec47
Attachment #484019 -
Attachment description: rebased patch (fix for compartments) → [checked-in] rebased patch (fix for compartments)
Updated•14 years ago
|
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•