Closed Bug 603211 Opened 14 years ago Closed 14 years ago

Fix test: browser_webconsole_bug_595350_multiple_windows_and_tabs.js

Categories

(DevTools :: General, defect)

x86
All
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ddahl, Assigned: msucan)

References

Details

(Whiteboard: [patchclean:1018])

Attachments

(1 file, 1 obsolete file)

This test fails and/or asserts, needs a re-factor. For one, it can probably only use 1 additional tab, as I do not see the benefit of using 3. So the test should be: open 2 tabs, log and check output. open a new window with 1 tab, log and check output, close window, log more messages and check output.
Depends on: 581069
Assignee: nobody → mihai.sucan
Blocks: devtools4b8
Attached patch proposed fix (obsolete) (deleted) — Splinter Review
Proposed fix. Please note that there's a small fix for head.js to not close the last tab, when the test that just executed already does that. The browser_webconsole_bug_595350_multiple_windows_and_tabs.js test file needs to close the tabs it opens to check after that the state of the HUDService. If head.js closes the last tab, then the last window also closes, which breaks all other tests. So, the simple fix is to close all tabs, except the last one. No regressions are caused by this small change.
Attachment #483134 - Flags: feedback?(ddahl)
Status: NEW → ASSIGNED
Whiteboard: [patchclean:1014]
Comment on attachment 483134 [details] [diff] [review] proposed fix nice catch in head.js
Attachment #483134 - Flags: feedback?(ddahl) → feedback+
I can push this without review as it is a test change. Let me do some testing first.
Adding checkin-needed, given it's only a test change.
Keywords: checkin-needed
Patch fixed for the compartments landing.
Attachment #483134 - Attachment is obsolete: true
Whiteboard: [patchclean:1014] → [patchclean:1018]
this requires review.
Keywords: checkin-needed
Attachment #484057 - Flags: review?(gavin.sharp)
Comment on attachment 484057 [details] [diff] [review] [checked-in] rebased patch and fixed for the compartments landing Looks like you can remove this test from the comment at the end of head.js as well. The other head.js change makes me wonder what the effect these console tests have on the state of the browser during the test run. Not related to this bug in any way, but it'd be an interesting experiment to write code that logs of event listeners added/nodes in document/etc. to see how the browser's state changes during mochitest/browserchrome/etc. test runs.
Attachment #484057 - Flags: review?(gavin.sharp) → review+
Comment on attachment 484057 [details] [diff] [review] [checked-in] rebased patch and fixed for the compartments landing http://hg.mozilla.org/mozilla-central/rev/4da5ab8255ec
Attachment #484057 - Attachment description: rebased patch and fixed for the compartments landing → [checked-in] rebased patch and fixed for the compartments landing
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: