Closed
Bug 603211
Opened 14 years ago
Closed 14 years ago
Fix test: browser_webconsole_bug_595350_multiple_windows_and_tabs.js
Categories
(DevTools :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ddahl, Assigned: msucan)
References
Details
(Whiteboard: [patchclean:1018])
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
Gavin
:
review+
Gavin
:
approval2.0+
|
Details | Diff | Splinter Review |
This test fails and/or asserts, needs a re-factor. For one, it can probably only use 1 additional tab, as I do not see the benefit of using 3.
So the test should be: open 2 tabs, log and check output.
open a new window with 1 tab, log and check output, close window, log more messages and check output.
Updated•14 years ago
|
Assignee: nobody → mihai.sucan
Blocks: devtools4b8
Assignee | ||
Comment 1•14 years ago
|
||
Proposed fix.
Please note that there's a small fix for head.js to not close the last tab, when the test that just executed already does that. The browser_webconsole_bug_595350_multiple_windows_and_tabs.js test file needs to close the tabs it opens to check after that the state of the HUDService. If head.js closes the last tab, then the last window also closes, which breaks all other tests. So, the simple fix is to close all tabs, except the last one. No regressions are caused by this small change.
Attachment #483134 -
Flags: feedback?(ddahl)
Assignee | ||
Updated•14 years ago
|
Status: NEW → ASSIGNED
Whiteboard: [patchclean:1014]
Reporter | ||
Comment 2•14 years ago
|
||
Comment on attachment 483134 [details] [diff] [review]
proposed fix
nice catch in head.js
Attachment #483134 -
Flags: feedback?(ddahl) → feedback+
Reporter | ||
Comment 3•14 years ago
|
||
I can push this without review as it is a test change. Let me do some testing first.
Assignee | ||
Comment 4•14 years ago
|
||
Adding checkin-needed, given it's only a test change.
Keywords: checkin-needed
Assignee | ||
Comment 5•14 years ago
|
||
Patch fixed for the compartments landing.
Attachment #483134 -
Attachment is obsolete: true
Assignee | ||
Updated•14 years ago
|
Whiteboard: [patchclean:1014] → [patchclean:1018]
Updated•14 years ago
|
Attachment #484057 -
Flags: review?(gavin.sharp)
Comment 7•14 years ago
|
||
Comment on attachment 484057 [details] [diff] [review]
[checked-in] rebased patch and fixed for the compartments landing
Looks like you can remove this test from the comment at the end of head.js as well.
The other head.js change makes me wonder what the effect these console tests have on the state of the browser during the test run. Not related to this bug in any way, but it'd be an interesting experiment to write code that logs of event listeners added/nodes in document/etc. to see how the browser's state changes during mochitest/browserchrome/etc. test runs.
Attachment #484057 -
Flags: review?(gavin.sharp) → review+
Updated•14 years ago
|
Attachment #484057 -
Flags: approval2.0+
Comment 8•14 years ago
|
||
Comment on attachment 484057 [details] [diff] [review]
[checked-in] rebased patch and fixed for the compartments landing
http://hg.mozilla.org/mozilla-central/rev/4da5ab8255ec
Attachment #484057 -
Attachment description: rebased patch and fixed for the compartments landing → [checked-in] rebased patch and fixed for the compartments landing
Updated•14 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•