Closed
Bug 603265
Opened 14 years ago
Closed 12 years ago
Importing a .cvf with empty lines doesn't work
Categories
(MailNews Core :: Import, defect)
MailNews Core
Import
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 15.0
People
(Reporter: Usul, Assigned: leon.sha)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
Bienvenu
:
review+
|
Details | Diff | Splinter Review |
In bug 600798 there are two vcard that are suposed to work with the code added in bug 79709. The first one works, the second one doesn't.
Files can be found at http://hg.mozilla.org/qa/litmus-data/file/947e21f848da/thunderbird/import the emptylines_vcard_addressbook.vcf is the faulty file.
|
Reporter | |
Updated•13 years ago
|
OS: Mac OS X → All
Filter out the empty line.
Attachment #622993 -
Flags: review?
Attachment #622993 -
Flags: review? → review?(dbienvenu)
|
||
Updated•12 years ago
|
Assignee: nobody → leon.sha
Status: NEW → ASSIGNED
Hardware: x86 → All
|
||
Comment 3•12 years ago
|
||
Comment on attachment 622993 [details] [diff] [review]
patch
you could instead use do while and pass in aMore directly to ReadLine, so the code would look like this:
do {
rv = aLineStream->ReadLine(line, aMore);
}
while (line.IsEmpty() && *aMore);
if (!*aMore)
return rv;
Attachment #622993 -
Flags: review?(dbienvenu) → review+
|
|
Reporter | |
Updated•12 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Updated•12 years ago
|
Target Milestone: --- → Thunderbird 15.0
You need to log in
before you can comment on or make changes to this bug.
Description
•