Closed
Bug 603311
Opened 14 years ago
Closed 14 years ago
HashMgr::load_tables leaks dict when decode_flags fails
Categories
(Core :: Spelling checker, defect)
Core
Spelling checker
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| status1.9.2 | --- | ? |
People
(Reporter: timeless, Assigned: timeless)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, memory-leak, Whiteboard: [fixed-in-hunspell-1.2.13])
Attachments
(1 file)
|
(deleted),
patch
|
caolanm
:
review+
roc
:
approval2.0+
|
Details | Diff | Splinter Review |
406 int HashMgr::load_tables(const char * tpath, const char * key)
416 FileMgr * dict = new FileMgr(tpath, key);
492 if (ap) {
494 if (aliasf) {
501 } else {
502 al = decode_flags(&flags, ap + 1, dict);
503 if (al == -1) {
504 HUNSPELL_WARNING(stderr, "Can't allocate memory.\n");
505 return 6;
|
||
Updated•14 years ago
|
Attachment #482397 -
Flags: review?(ryanvm) → review?(caolanm)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 482397 [details] [diff] [review]
patch
yes, looks good, committed to hunspell cvs
Attachment #482397 -
Flags: review?(caolanm) → review+
|
|
||
Updated•14 years ago
|
Whiteboard: [fixed-in-hunspell-1.2.13]
|
|
||
Updated•14 years ago
|
Depends on: hunspell-1.3.2
|
||
Updated•14 years ago
|
Attachment #482397 -
Flags: approval2.0?
Attachment #482397 -
Flags: approval2.0? → approval2.0+
|
|
||
Updated•14 years ago
|
Whiteboard: [fixed-in-hunspell-1.2.13] → [fixed-in-hunspell-1.2.13][needs landing]
|
|
||
Updated•14 years ago
|
Keywords: checkin-needed
|
||
Comment 3•14 years ago
|
||
Keywords: checkin-needed
|
|
||
Updated•14 years ago
|
|
|
||
Updated•14 years ago
|
Whiteboard: [fixed-in-hunspell-1.2.13][needs landing] → [fixed-in-hunspell-1.2.13]
|
|
||
Comment 4•14 years ago
|
||
I think you need to request branch approval, Ryan, if you want this on 1.9.2.
|
||
Updated•6 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•