Closed
Bug 603899
Opened 14 years ago
Closed 14 years ago
Probable failure to build due to unexpected change from bug 522770
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla2.0b7
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
benjamin
:
review+
benjamin
:
approval2.0+
|
Details | Diff | Splinter Review |
The landed patch from bug 522770 includes the following hunk:
@@ -539,17 +539,18 @@ xptcstubs_asm_openvms_alpha.o: $(DIST)/i
endif
ifeq ($(OS_ARCH),SunOS)
ifeq (86,$(findstring 86,$(OS_TEST)))
ifndef GNU_CC
ifeq (x86_64,$(OS_TEST))
xptcstubs_asm_x86_64_solaris_SUNW.o: $(DIST)/include/xptcstubsdef.inc $(srcdir)/xptcstubs_asm_x86_64_solaris_SUNW.s
sed \
- -e 's/^\(STUB_ENTRY\)(\([0-9]\))/\11\(\2\)/' \
+ -e 's/^\(STUB_ENTRY\)(\([0
+-9]\))/\11\(\2\)/' \
-e 's/^\(STUB_ENTRY\)(\([0-9][0-9]\))/\12\(\2\)/' \
-e 's/^\(STUB_ENTRY\)(\([0-9][0-9][0-9]\))/\13\(\2\)/' \
$(DIST)/include/xptcstubsdef.inc > ./xptcstubsdef_asm.solx86
$(AS) -o $@ -xarch=amd64 $(ASFLAGS) $(AS_DASH_C_FLAG) -I./ $(srcdir)/xptcstubs_asm_x86_64_solaris_SUNW.s
else
xptcstubs_asm_x86_solaris_SUNW.o: $(DIST)/include/xptcstubsdef.inc $(srcdir)/xptcstubs_asm_x86_solaris_SUNW.s
sed \
-e 's/^\(STUB_ENTRY\)(\([0-9]\))/\11\(\2\)/' \
This is very likely to break. It should be reverted.
Attachment #482800 -
Flags: review?(benjamin)
|
||
Comment 1•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
|
||
Comment 3•14 years ago
|
||
Comment on attachment 482800 [details] [diff] [review]
Revert broken (and unrelated) hunk from bug 522770
Yeah, that has to be accidental.
Attachment #482800 -
Flags: review?(benjamin) → review+
|
|
||
Updated•14 years ago
|
Attachment #482800 -
Flags: approval2.0+
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → mh+mozilla
|
|
Assignee | |
Comment 4•14 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
|
||
Updated•14 years ago
|
Target Milestone: mozilla2.0b8 → mozilla2.0b7
You need to log in
before you can comment on or make changes to this bug.
Description
•