Closed
Bug 603985
(fx40-p12n-ko)
Opened 14 years ago
Closed 14 years ago
[ko] Firefox 4.0 productization review for Korean
Categories
(Mozilla Localizations :: ko / Korean, defect)
Mozilla Localizations
ko / Korean
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: stas, Assigned: channy)
References
Details
(Keywords: productization, Whiteboard: [l10n-src-verification updated])
Attachments
(2 files)
(deleted),
patch
|
sethb
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
sethb
:
review+
|
Details | Diff | Splinter Review |
As you might have seen in the newsgroups or on the Mozilla blog, there's a couple of changes to search engines planned for the 4.0 release for en-US: <http://groups.google.com/group/mozilla.dev.l10n/msg/81073d8d67e1c4c3>. We would like to use this opportunity to review the current productization setup for Korean and make any changes that you think will be good for our users.
What is a productization review?
================================
Here's what we're interested in:
* search engines,
* protocol handlers,
* feed readers,
* live bookmark.
You can see what your locale currently ships with at <http://hg.mozilla.org/l10n/l10n-src-verification/file/default/reference/browser/2.0/ko>
Please take a moment and review the choice of services available by default in your locale. If there have been any new services that have recently gained popularity and that offer good value for the users, please suggest adding them to your locale. On the other hand, if there are services that lost credibility (e.g. display too many adds) or have poor user experience, consider suggesting that we remove them. If in doubt, feel free to make a suggestion and we'll look at it together. You might find the guidelines at <https://wiki.mozilla.org/L10n:Productization> and <https://wiki.mozilla.org/L10n:Firefox/Productization> helpful, too.
Required changes
================
There's two things I would like to draw your attention to (if applicable):
1) if you have a google.xml file in your `searchplugins` directory, please remove it,
2) Bloglines is closing down on November 1st and we need to remove it from the feed reader options for all locales (see bug 595485). We suspect that it will make sense to move Google Reader up to the first position (if your locale has it). We will be offering technical help with this change, either in form of ready-made patches or a mass-landing by one of the l10n-drivers. If you don't think that moving Google Reader up is a good idea for your locale, please let us know!
Changes in en-US and en-GB
==========================
Here's the changes that we will be making in en-US and en-GB:
* add Bing as the 3rd general search engine (see bug 603298),
* remove Answers,
* remove Creative Commons.
We're making these changes in en-US and en-GB because we feel that they follow the recent market trends and user preferences in the US and the UK. We would like to go through the same thought process for your locale and see if any of these changes would make sense in Korean builds as well. If you decide that implementing these changes would be in your users' best interest then please go ahead and include them in the patch you'll attach to this bug.
Implementation
==============
Please make suggestions for changes and attach patches that Seth, Axel or I will review. Please note that since Bing provides a global plugin which does the locale detection itself, you will only need to add "bing" to your list.txt if you decide to include it. The XML file will be automatically pulled from en-US.
Once a review is granted, you can land the patch on l10n-central if your locale actively maintains it. Otherwise, please wait for further instructions which will be put in the comments of this bug and announced in mozilla.dev.l10n (we're still unsure when the branching will happen). Please do not land any changes except for the required ones (google.xml, Bloglines) on 1.9.2.
If you do not wish to make any changes, let us know, and we'll only work on removing Bloglines.
Thanks!
Comment 1•14 years ago
|
||
Bloglines still remains in your 1.9.2 repository. Please prepare a patch to remove it.
Also, if you have any productization changes to make for Firefox 4, like the Bing suggestion listed in comment 0, please provide a patch to make that change on l10n-central. Thank you.
Assignee | ||
Comment 2•14 years ago
|
||
Attachment #493564 -
Flags: review?(stas)
Assignee | ||
Comment 3•14 years ago
|
||
I noticed some of changes in Korean community http://forums.mozilla.or.kr/viewtopic.php?f=2&t=14022 and I got some of feedback.
1. Korea's Bing.com has been managed by Daum's search result by contraction between Microsoft and Daum. So we don't add bing in search plug-in.
2. We'll remove creative commons as like en-US version.
3. We'll remove bloglines as like en-US version.
Assignee | ||
Comment 4•14 years ago
|
||
Changes of Firefox 4.0 Korean production.
Attachment #493566 -
Flags: review?(stas)
Comment 5•14 years ago
|
||
Comment on attachment 493564 [details] [diff] [review]
Remove Bloglines for 1.9.2
Thank you. Please check this into 1.9.2 and add a comment that references bug 603958 and the change.
Attachment #493564 -
Flags: review?(stas) → review+
Comment 6•14 years ago
|
||
Comment on attachment 493566 [details] [diff] [review]
Changes for Firefox 4.0 ko production
Looks good to me, although removing CC is not *obligatory* since you are not adding Bing due to the Daum relationship. However, you are free to remove it as you have done.
Please check this into l10n-central, adding a comment that references bug 603985 and the change. After you have tested your nightly, please don't forget to sign off.
If all looks good on 1.9.2 (please sign off there too) and l10n-central, you may resolve this bug as fixed.
Attachment #493566 -
Flags: review?(stas) → review+
Assignee | ||
Comment 7•14 years ago
|
||
(In reply to comment #5)
> Comment on attachment 493564 [details] [diff] [review]
> Remove Bloglines for 1.9.2
>
> Thank you. Please check this into 1.9.2 and add a comment that references bug
> 603958 and the change.
fixed in http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/ko/rev/1739462b59b1
Assignee | ||
Comment 8•14 years ago
|
||
(In reply to comment #6)
> Comment on attachment 493566 [details] [diff] [review]
> Changes for Firefox 4.0 ko production
>
> Looks good to me, although removing CC is not *obligatory* since you are not
> adding Bing due to the Daum relationship. However, you are free to remove it
> as you have done.
>
> Please check this into l10n-central, adding a comment that references bug
> 603985 and the change. After you have tested your nightly, please don't forget
> to sign off.
>
> If all looks good on 1.9.2 (please sign off there too) and l10n-central, you
> may resolve this bug as fixed.
fixed in http://hg.mozilla.org/l10n-central/ko/rev/bc85b5988250
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 9•14 years ago
|
||
(In reply to comment #7)
> (In reply to comment #5)
> > Comment on attachment 493564 [details] [diff] [review] [details]
> > Remove Bloglines for 1.9.2
> >
> > Thank you. Please check this into 1.9.2 and add a comment that references bug
> > 603958 and the change.
>
> fixed in http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/ko/rev/1739462b59b1
This landing is different than the r+'ed patch from attachment 493564 [details] [diff] [review]. Can you please reorder Google Reader to position no. 1 and My Yahoo! to position no. 2 and land on 1.9.2 again?
(Also note that "My Yahoo!" should have an exclamation mark at the end of its name. Can you change this on both 1.9.2 and central?)
Thanks.
Status: RESOLVED → UNCONFIRMED
Ever confirmed: false
Resolution: FIXED → ---
Reporter | ||
Comment 10•14 years ago
|
||
I'm sorry, I meant to reopen, and not change to "unconfirmed" :/
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Comment 11•14 years ago
|
||
(In reply to comment #9)
> (In reply to comment #7)
> > (In reply to comment #5)
> > > Comment on attachment 493564 [details] [diff] [review] [details] [details]
> > > Remove Bloglines for 1.9.2
> > >
> > > Thank you. Please check this into 1.9.2 and add a comment that references bug
> > > 603958 and the change.
> >
> > fixed in http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/ko/rev/1739462b59b1
>
> This landing is different than the r+'ed patch from attachment 493564 [details] [diff] [review]. Can you
> please reorder Google Reader to position no. 1 and My Yahoo! to position no. 2
> and land on 1.9.2 again?
>
> (Also note that "My Yahoo!" should have an exclamation mark at the end of its
> name. Can you change this on both 1.9.2 and central?)
>
> Thanks.
Oh. I missed different repository. fixed in http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/ko/rev/cfab590fee4c
Status: NEW → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 12•14 years ago
|
||
Thanks Channy. I update the l10n-src-verification in https://hg.mozilla.org/l10n/l10n-src-verification/rev/7cb56665013f.
Whiteboard: [l10n-src-verification updated]
You need to log in
before you can comment on or make changes to this bug.
Description
•