As you might have seen in the newsgroups or on the Mozilla blog, there's a couple of changes to search engines planned for the 4.0 release for en-US: <http://groups.google.com/group/mozilla.dev.l10n/msg/81073d8d67e1c4c3>. We would like to use this opportunity to review the current productization setup for Punjabi and make any changes that you think will be good for our users. What is a productization review? ================================ Here's what we're interested in: * search engines, * protocol handlers, * feed readers, * live bookmark. You can see what your locale currently ships with at <http://hg.mozilla.org/l10n/l10n-src-verification/file/default/reference/browser/2.0/pa-IN> Please take a moment and review the choice of services available by default in your locale. If there have been any new services that have recently gained popularity and that offer good value for the users, please suggest adding them to your locale. On the other hand, if there are services that lost credibility (e.g. display too many adds) or have poor user experience, consider suggesting that we remove them. If in doubt, feel free to make a suggestion and we'll look at it together. You might find the guidelines at <https://wiki.mozilla.org/L10n:Productization> and <https://wiki.mozilla.org/L10n:Firefox/Productization> helpful, too. Required changes ================ There's two things I would like to draw your attention to (if applicable): 1) if you have a google.xml file in your `searchplugins` directory, please remove it, 2) Bloglines is closing down on November 1st and we need to remove it from the feed reader options for all locales (see bug 595485). We suspect that it will make sense to move Google Reader up to the first position (if your locale has it). We will be offering technical help with this change, either in form of ready-made patches or a mass-landing by one of the l10n-drivers. If you don't think that moving Google Reader up is a good idea for your locale, please let us know! Changes in en-US and en-GB ========================== Here's the changes that we will be making in en-US and en-GB: * add Bing as the 3rd general search engine (see bug 603298), * remove Answers, * remove Creative Commons. We're making these changes in en-US and en-GB because we feel that they follow the recent market trends and user preferences in the US and the UK. We would like to go through the same thought process for your locale and see if any of these changes would make sense in Punjabi builds as well. If you decide that implementing these changes would be in your users' best interest then please go ahead and include them in the patch you'll attach to this bug. Implementation ============== Please make suggestions for changes and attach patches that Seth, Axel or I will review. Please note that since Bing provides a global plugin which does the locale detection itself, you will only need to add "bing" to your list.txt if you decide to include it. The XML file will be automatically pulled from en-US. Once a review is granted, you can land the patch on l10n-central if your locale actively maintains it. Otherwise, please wait for further instructions which will be put in the comments of this bug and announced in mozilla.dev.l10n (we're still unsure when the branching will happen). Please do not land any changes except for the required ones (google.xml, Bloglines) on 1.9.2. If you do not wish to make any changes, let us know, and we'll only work on removing Bloglines. Thanks!

I would like to add bing in search engine. Nothing else need to change for Punjabi.

A-preet: If you would like to add Bing, please prepare a patch for l10n-central that adds Bing to your list.txt file. That is all you will need to do. Attach the patch here, I'll review it, and you can check it in from there.

Also, Bloglines still remains in your 1.9.2 repository. Please prepare a patch to remove it. However please note the new update about Bloglines below. Mozilla has been contacted by the new owners of Bloglines who have said they will keep the service running. If you have no other options, you can consider leaving it. However, it is hard to say whether that team who is now in control of Bloglines will change their mind again. The l10n-drivers feel that it would be best to remove it altogether.

Added patch for review.

Comment on attachment 492171 [details] [diff] [review] Patch to add bing search engine Look good. Please check this into l10n-central *only*. Add a comment to that checkin referencing bug 604001 and this change. Please sign off when you make this change.

I assume you are not choosing to remove Bloglines from 1.9.2? The recommendation is to remove them, even though we recently learned that the service will still be available. From the l10n-drivers perspective, it seems hard to predict if Bloglines' existence will continue to be uncertain as has been in the past 6 weeks, so we recommend just removing it.

bing is in with following detail --- changeset: 227:bbdb0003c4d5 ---

Apreet: What about Bloglines on 1.9.2? Do you want to remove that, too? All other locales are going to take it out. I recommend you do that, too.

patch to remove bloglines, but would like to know if need to move browser.contentHandlers.types.1.title->browser.contentHandlers.types.0.title browser.contentHandlers.types.2.title->browser.contentHandlers.types.1.title browser.contentHandlers.types.2.title -> REMOVE

(In reply to comment #9) > Created attachment 493486 [details] [diff] [review] > patch to remove Blogline > > patch to remove bloglines, but would like to know if need to move > browser.contentHandlers.types.1.title->browser.contentHandlers.types.0.title > browser.contentHandlers.types.2.title->browser.contentHandlers.types.1.title > browser.contentHandlers.types.2.title -> REMOVE Yes, exactly, you'll need to increment those as you suggested.

Comment on attachment 493486 [details] [diff] [review] patch to remove Blogline Should look like this: browser.contentHandlers.types.0.title=Google browser.contentHandlers.types.0.uri=http://fusion.google.com/add?feedurl=%s browser.contentHandlers.types.1.title=My Yahoo! browser.contentHandlers.types.1.uri=http://add.my.yahoo.com/rss?url=%s

updated patch attached. Please review this.

Comment on attachment 493523 [details] [diff] [review] patch to remove Blogline (updated) Please commit to 1.9.2 adding a comment that references this change, r=sethb, and bug 604001. Please sign off after you have tested the commit so it gets picked up in the next release.

After you have tested and signed off, you can close this bug, resolving it as fixed.

I tested the changes in Firefox 4 latest build on Linux. Both issue fixed. check 1.9.2 later and update ASAP.

Reopen if there are any issues, but I assume we are "A-OK".

Reopening (sorry) Per eBay's request, please update the search plugin to be included with Mozilla products per the attached patch. The changes add suggested search, an updated favicon, and changes the base search URL. This change will normalize the version of eBay's plugin for India, and should block Fx4 for all *-IN locales that include eBay. Note that any previously included params should not be re-introduced. If there are any questions, please let me know.

Comment on attachment 503184 [details] [diff] [review] Updated eBay search plugin Kev, small nit on this one. There is a "\ No newline at end of file" in this plugin. Can you get rid of that diff flotsam and jetsam and reattach?

per comment #18, remove garbage and re-submit for review.

Comment on attachment 505448 [details] [diff] [review] Updated eBay search plugin This looks good. Thank you, Kev. Apreet, as mentioned in the bug, can you please check this new eBay plugin into your L10n-central repository. Please test the new build and sign off. Once you have signed off, please resolve this bug again as fixed.

hi, I tried to apply patch. Please check if following output can be correct to commit. ----- $ patch -p8 browser/searchplugins/eBay-in.xml ebay-pa-IN.patch patching file browser/searchplugins/eBay-in.xml Hunk #1 succeeded at 1 with fuzz 1. ----

I committed patch with following charset: --- changeset: 262:79ac8701e177 --- I will confirm changes once and close bug after that.

Comment on attachment 505448 [details] [diff] [review] Updated eBay search plugin Can I have this one as XML, please? http://hg.mozilla.org/l10n-central/pa-IN/diff/79ac8701e177/browser/searchplugins/eBay-in.xml landed with just that. It's missing a "<S" at the start of the file.

Still Firefox Search Engine list don't seems to match with customization with pa-IN folder (browser/searchplugins/list.txt) list.txt: google yahoo-in eBay-in wikipedia-pa bing my firefox 4Beta10 showing: Google Yahoo (http://search.yahoo.com/search?p=aman&ei=UTF-8&fr=moz35 Search url not from Yahoo India) Amazon.com Bing eBay Wikipedia (en) any problem from locale?

Apreet -- Can you do a "fresh install" of the Minefield nightly from here: http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-central-l10n/ I have tested the Punjabi version and I see 4 search plugins: Google Yahoo In Bing Wikipedia (pa) Have you landed and signed off on the eBay plugin? That seems to be absent.

thanks for checking, I will check 'fresh install' > Have you landed and signed off on the eBay plugin? That seems to be absent. I signed of it on following date: 2011-01-25 effect of comment #23? can I update xml file (by add <S)?

xml fix landed, signed-off and taken, and l10n-src-verification updated. Marking FIXED.

Note: the added |type="image/x-icon"| on the <Image> is unnecessary - the search service does not make use of the "type" attribute on Image elements. You should feel free to remove it.