Closed
Bug 604190
Opened 14 years ago
Closed 14 years ago
nsEventStateManager.cpp:2776: warning: 'bool NodeAllowsClickThrough(nsINode*)' defined but not used
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla2.0b8
People
(Reporter: dholbert, Assigned: mstange)
References
Details
(Whiteboard: [build_warning])
Attachments
(1 file)
|
(deleted),
patch
|
smaug
:
review+
benjamin
:
approval2.0+
|
Details | Diff | Splinter Review |
We get this build warning on non-MacOS:
> content/events/src/nsEventStateManager.cpp: At global scope:
> content/events/src/nsEventStateManager.cpp:2776: warning: 'bool NodeAllowsClickThrough(nsINode*)' defined but not used
That static function is currently defined unconditionally, but is only called from an #ifdef XP_MACOSX block:
http://hg.mozilla.org/mozilla-central/diff/e18854fb9aed/content/events/src/nsEventStateManager.cpp
Warning easily fixable by adding an #ifdef XP_MACOSX around the method. (No point in defining it on platforms that don't use it.)
|
Assignee | |
Comment 1•14 years ago
|
||
|
||
Updated•14 years ago
|
Attachment #492351 -
Flags: review?(Olli.Pettay) → review+
|
|
Assignee | |
Updated•14 years ago
|
Attachment #492351 -
Flags: approval2.0?
|
||
Updated•14 years ago
|
Attachment #492351 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Comment 2•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•