Closed
Bug 604457
Opened 14 years ago
Closed 14 years ago
switchToTabHavingURI shouldn't close selected tab or revert URL bar
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 4.0b8
People
(Reporter: Gavin, Assigned: dao)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
Gavin
:
approval2.0+
|
Details | Diff | Splinter Review |
Closing the selected tab and reverting the URL bar are autocomplete-specific actions, so they should be done in the urlbarBindings handler if switchToTabHavingURI returns true. They aren't useful for other callers of switchToTabHavingURI (e.g. opening the addons manager).
|
Assignee | |
Updated•14 years ago
|
Blocks: switch-to-tab, 555767
|
|
Assignee | |
Comment 1•14 years ago
|
||
I don't think the return value needs to be checked here, switchToTabHavingURI should always succeed.
|
Reporter | |
Comment 2•14 years ago
|
||
Comment on attachment 488450 [details] [diff] [review]
patch
I think you should check the return value before calling removeTab(prevTab), because we have bugs where we end up calling switchToTabHavingURI for nonexistent URIs (bug 558626), and it doesn't really hurt to be resilient. r=me with that.
Attachment #488450 -
Flags: review?(gavin.sharp) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Attachment #488450 -
Attachment is obsolete: true
Attachment #488641 -
Flags: approval2.0?
|
|
Reporter | |
Updated•14 years ago
|
Attachment #488641 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Comment 4•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b8
You need to log in
before you can comment on or make changes to this bug.
Description
•