Closed
Bug 604644
Opened 14 years ago
Closed 14 years ago
Default repository_url broken for non-Firefox apps.
Categories
(Mozilla QA Graveyard :: Mozmill Automation, defect)
Mozilla QA Graveyard
Mozmill Automation
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: standard8, Assigned: standard8)
References
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
patch
|
whimboo
:
review+
|
Details | Diff | Splinter Review |
Bug 571978 broke the setting of the default repository_url for non-Firefox apps.
In TestRun's __init__ function, we have:
http://hg.mozilla.org/qa/mozmill-automation/file/c19cc0f1d54a/libs/testrun.py#l70
def __init__(self):
self.application = "firefox"
...
self.repository_url = MOZMILL_TESTS_REPOSITORIES[self.application]
This means that the url is always going to be set for Firefox.
The current set-up of the code is that __init__ will get called, and then the individual members are set. I think we should just change this so that each class declares which variables it can take, and have them passed at initialisation. Then we can choose a sensible default or what has been passed in as appropriate.
I'm attaching a patch for this. I've only run the update tests, but I think it should all work.
Attachment #483459 -
Flags: review?(hskupin)
Comment 1•14 years ago
|
||
Good catch Mark, and I'm sorry that I missed that. Your work here already fixes a part of the work I have planned on bug 566761. Lets see what's left over there. Thanks for the patch.
Comment 2•14 years ago
|
||
Comment on attachment 483459 [details] [diff] [review]
The fix
Looks good and seems to include all the work from the other bug! Awesome.
Attachment #483459 -
Flags: review?(hskupin) → review+
Comment 3•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment 4•14 years ago
|
||
Move of Mozmill related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.
Component: Mozmill Tests → Mozmill Automation
Product: Testing → Mozilla QA
QA Contact: mozmill-tests → mozmill-automation
Whiteboard: [mozmill-automation]
Version: Trunk → unspecified
Updated•11 years ago
|
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•