Closed
Bug 604673
Opened 14 years ago
Closed 14 years ago
<output> should be subject for constraint validation
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla2.0b8
People
(Reporter: mounir, Assigned: mounir)
References
Details
(Keywords: dev-doc-complete, html5, Whiteboard: [good first bug])
Attachments
(1 file)
|
(deleted),
patch
|
smaug
:
review+
limi
:
ui-review+
benjamin
:
approval2.0+
|
Details | Diff | Splinter Review |
We are currently following the specifications but that seems to be wrong. It would be nice to have .setCustomValidity() working with <output>.
|
Assignee | |
Comment 1•14 years ago
|
||
|
|
Assignee | |
Updated•14 years ago
|
Keywords: dev-doc-needed
Whiteboard: [good first bug]
|
|
Assignee | |
Updated•14 years ago
|
Summary: <output> should not be barred from constraint validation → <output> should be subject for constraint validation
|
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → mounir.lamouri
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•14 years ago
|
||
Attachment #484085 -
Flags: review?(Olli.Pettay)
|
||
Comment 3•14 years ago
|
||
What is the status of the spec change?
|
|
Assignee | |
Comment 4•14 years ago
|
||
The bug still got no answer but I think we should ship with this change and see, this way, if there is a real need. FWIW, Jonas was supporting this plan.
|
|
||
Comment 5•14 years ago
|
||
Comment on attachment 484085 [details] [diff] [review]
Patch v1
>-:invalid {
>+:not(output):invalid {
> box-shadow: 0 0 1.5px 1px red;
> }
>
>+output:invalid {
>+ color: red;
>+}
>+
I think this change should get ui-review.
Attachment #484085 -
Flags: review?(Olli.Pettay) → review+
|
|
Assignee | |
Updated•14 years ago
|
Attachment #484085 -
Flags: ui-review?(limi)
Attachment #484085 -
Flags: approval2.0?
|
||
Updated•14 years ago
|
Attachment #484085 -
Flags: approval2.0? → approval2.0+
|
||
Comment 6•14 years ago
|
||
Comment on attachment 484085 [details] [diff] [review]
Patch v1
If this works the way I think it does, it should be fine. I'm a bit hazy on the use of the HTML5 <output> element, and would love to see a demo of how this would be done in a real-life situation, though.
Don't let that stop this from shipping in a beta for wider feedback, though. :)
Attachment #484085 -
Flags: ui-review?(limi) → ui-review+
|
|
Assignee | |
Comment 7•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
|
||
Comment 8•14 years ago
|
||
I've documented this, and marked it as non-standard (https://developer.mozilla.org/en/DOM/HTMLOutputElement). If/when the spec is changed, we'll need to remove the non-standard label.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•