Closed
Bug 604735
Opened 14 years ago
Closed 14 years ago
artifact (line) shows at left edge of tab just as tab close animation completes
Categories
(Firefox :: Tabbed Browser, defect)
Firefox
Tabbed Browser
Tracking
()
RESOLVED
FIXED
Firefox 4.0b8
People
(Reporter: beltzner, Assigned: dao)
Details
Attachments
(3 files)
(deleted),
video/quicktime
|
Details | |
(deleted),
patch
|
Gavin
:
review+
Gavin
:
approval2.0+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Details | Diff | Splinter Review |
See attached .mov
Anyone know what's causing that?
Reporter | ||
Comment 1•14 years ago
|
||
Assignee | ||
Comment 2•14 years ago
|
||
The tab has a width of 1px there; what you see is the CSS borders.
Assignee: nobody → dao
Component: Theme → Tabbed Browser
OS: Mac OS X → All
QA Contact: theme → tabbed.browser
Hardware: x86 → All
Reporter | ||
Comment 3•14 years ago
|
||
(In reply to comment #2)
> The tab has a width of 1px there; what you see is the CSS borders.
We should optimize the tab-close so that it vanishes after the tab is 3px wide, I think.
Assignee | ||
Comment 4•14 years ago
|
||
This hides the tab for the last 20ms of the closing transition and for the first 20ms of the opening transition.
It also changes the transition target resp. start width from 1px to 0 (using 0.1px because min-width:0 would disable the min-width altogether).
I tried 3px, but that wouldn't fix the bug, as that's still to narrow to draw the border properly, at least on Windows an Linux. It also caused a visible jump at the end of the transition.
Attachment #483670 -
Flags: review?(gavin.sharp)
Comment 5•14 years ago
|
||
Comment on attachment 483670 [details] [diff] [review]
patch
Can you add some comments? It took me a while to figure out why the different values were what they are.
I'm assuming the idea is that (180ms delay)+(50ms "fade out" transition)+(20ms of opacity=0) is equal to the 250ms max-width transition length (for the closing case).
Attachment #483670 -
Flags: review?(gavin.sharp) → review+
Updated•14 years ago
|
Attachment #483670 -
Flags: approval2.0+
Assignee | ||
Comment 6•14 years ago
|
||
Assignee | ||
Updated•14 years ago
|
Keywords: checkin-needed
Assignee | ||
Updated•14 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 7•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
No longer depends on: 608589
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b8
Updated•11 years ago
|
Attachment #483561 -
Attachment mime type: application/octet-stream → video/quicktime
You need to log in
before you can comment on or make changes to this bug.
Description
•