Closed
Bug 604901
Opened 14 years ago
Closed 14 years ago
Patch for bug 582466 breaks Quit in Cocoa embedders
Categories
(Core :: Widget: Cocoa, defect)
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
blocking2.0 | --- | - |
People
(Reporter: smichaud, Assigned: smichaud)
References
Details
Attachments
(2 files)
(deleted),
patch
|
jaas
:
review+
jaas
:
approval2.0+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Details | Diff | Splinter Review |
My patch for bug 582466 landed on the trunk yesterday (bug 582466 comment #47). Shortly after it landed I realized it would break Quitting in Cocoa embedders (like Camino). This problem is quite easy to work around: All that's needed is to disable the effects of my patch when running in a Cocoa embedder. Shortly I'll post a patch that does this. Currently there are no "official" Camino builds on the trunk (the most recent ones build on the 1.9.2 branch). And I don't know of any other Cocoa embedders that use our code. So to test the effects of my patch for bug 582466 I had to port it to the 1.9.2 branch and then build Camino off that code. I found that Quitting no longer works unless you do it from the Dock menu. This breakage is worse than what I estimated in bug 582466 comment #49. This fact, plus the fact that there's an easy fix, mean that we should land this fix as soon as possible. Even if there aren't currently any Cocoa embedders that use trunk code, this code will soon get into a release (Firefox 4), and Cocoa embedders will be tempted to start using it.
Assignee | ||
Comment 1•14 years ago
|
||
Don't replace the original -[NSApplication terminate:] method if we're running in a Cocoa embedder.
Assignee | ||
Comment 2•14 years ago
|
||
Here's the 1.9.2-branch patch I tested with (in Camino). It combines my patch for bug 582466 with my patch for this bug (bug 604901).
Assignee | ||
Updated•14 years ago
|
blocking2.0: --- → ?
Attachment #483744 -
Flags: review?(joshmoz)
Attachment #483744 -
Flags: review+
Attachment #483744 -
Flags: approval2.0+
Assignee | ||
Comment 3•14 years ago
|
||
Comment on attachment 483744 [details] [diff] [review] Fix Landed on trunk: http://hg.mozilla.org/mozilla-central/rev/9a313f3a32bc
Assignee | ||
Updated•14 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•