Closed
Bug 604941
Opened 14 years ago
Closed 14 years ago
new toolbar border is too opaque or too dark
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
FIXED
Firefox 4.0b8
People
(Reporter: asa, Assigned: dao)
References
Details
Attachments
(7 files)
(deleted),
image/png
|
Details | |
(deleted),
patch
|
shorlander
:
ui-review-
|
Details | Diff | Splinter Review |
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
patch
|
Gavin
:
review+
shorlander
:
ui-review+
Gavin
:
approval2.0+
|
Details | Diff | Splinter Review |
Today's nightly build has a new border around the toolbar which is significantly darker than it ought to be. Screenshots attached.
Reporter | ||
Comment 1•14 years ago
|
||
Assignee | ||
Updated•14 years ago
|
blocking2.0: --- → ?
Assignee | ||
Comment 2•14 years ago
|
||
Attachment #491180 -
Flags: ui-review?(shorlander)
Attachment #491180 -
Flags: review?(gavin.sharp)
Comment 3•14 years ago
|
||
Comment on attachment 491180 [details] [diff] [review]
40% @ 0.7 patch
The 40% grey is making it look rather washed out. Can we use a full black(or maybe 10%) at around .4 opacity instead?
This also makes the toolbar separator overlay the glass instead of the toolbar background. Although I am not sure if there is a way around that.
Attachment #491180 -
Flags: ui-review?(shorlander) → ui-review-
Assignee | ||
Comment 4•14 years ago
|
||
(In reply to comment #3)
> Comment on attachment 491180 [details] [diff] [review]
> patch
>
> The 40% grey is making it look rather washed out. Can we use a full black(or
> maybe 10%) at around .4 opacity instead?
This doesn't seem to work on dark glass. Screenshot coming up.
Assignee | ||
Comment 5•14 years ago
|
||
Assignee | ||
Updated•14 years ago
|
Attachment #491607 -
Attachment description: rgba(10%,10%,10%,.4) → rgba(10%,10%,10%,.4) on dark background
Assignee | ||
Comment 6•14 years ago
|
||
Assignee | ||
Comment 7•14 years ago
|
||
Assignee | ||
Comment 8•14 years ago
|
||
Assignee | ||
Updated•14 years ago
|
Attachment #491607 -
Attachment description: rgba(10%,10%,10%,.4) on dark background → 10% @ 0.4 / dark background
Assignee | ||
Updated•14 years ago
|
Attachment #491614 -
Attachment description: rgba(10%,10%,10%,.4) on light background → 10% @ 0.4 / light background
Assignee | ||
Updated•14 years ago
|
Attachment #491611 -
Attachment description: rgba(40%,40%,40%,.7) on dark background → 40% @ 0.7 / dark background
Assignee | ||
Updated•14 years ago
|
Attachment #491615 -
Attachment description: rgba(40%,40%,40%,.7) on light background → 40% @ 0.7 / light background
Comment 9•14 years ago
|
||
(In reply to comment #4)
> (In reply to comment #3)
> > Comment on attachment 491180 [details] [diff] [review] [details]
> > patch
> >
> > The 40% grey is making it look rather washed out. Can we use a full black(or
> > maybe 10%) at around .4 opacity instead?
>
> This doesn't seem to work on dark glass. Screenshot coming up.
Thanks for the screenshots.
I don't think this is a problem. Having it blend more on darker backgrounds is to be expected and do to the nature of Glass I don't think we can expect to be optimal in every scenario.
Even the 40% gray seems to become indistinguishable from the dark glass instead of overlaying.
Assignee | ||
Comment 10•14 years ago
|
||
Attachment #491620 -
Flags: ui-review?(shorlander)
Attachment #491620 -
Flags: review?(gavin.sharp)
Assignee | ||
Updated•14 years ago
|
Attachment #491180 -
Attachment description: patch → 40% @ 0.7 patch
Attachment #491180 -
Flags: review?(gavin.sharp)
Comment 11•14 years ago
|
||
Comment on attachment 491620 [details] [diff] [review]
10% @ 0.4 patch
Looks good. Thank you!
Attachment #491620 -
Flags: ui-review?(shorlander) → ui-review+
Comment 12•14 years ago
|
||
Comment on attachment 491620 [details] [diff] [review]
10% @ 0.4 patch
I don't understand what effect the background-clip change has (or what it's to supposed to have).
I don't think my review on these is very useful. You should probably just get Stephen to review simple CSS-only changes like this.
Attachment #491620 -
Flags: review?(gavin.sharp) → review+
Assignee | ||
Updated•14 years ago
|
Attachment #491620 -
Flags: approval2.0?
Updated•14 years ago
|
Attachment #491620 -
Flags: approval2.0? → approval2.0+
Assignee | ||
Comment 13•14 years ago
|
||
Status: NEW → RESOLVED
blocking2.0: ? → ---
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b8
You need to log in
before you can comment on or make changes to this bug.
Description
•