Closed
Bug 605352
Opened 14 years ago
Closed 14 years ago
JM: avoid double-pin in FrameState:syncFe
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: luke, Assigned: luke)
References
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
(deleted),
patch
|
sstangl
:
review+
|
Details | Diff | Splinter Review |
The attached patch avoids calling pinReg on an already-pinned register (since this loses save_) and adds an assert that we are not doing so.
Attachment #484200 -
Flags: review?(sstangl)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 484200 [details] [diff] [review]
patch
Looks good.
The assert in pin() can be changed to just:
> JS_ASSERT(fe_);
since assertConsistency() ensures that if (fe_), then (!save_).
Attachment #484200 -
Flags: review?(sstangl) → review+
|
Assignee | |
Comment 2•14 years ago
|
||
Whiteboard: fixed-in-tracemonkey
|
||
Comment 3•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•