We need to rename trace-tests/, for two reasons: - It's now used for the methodjit; - We'll be adding a tracejit/ dir soon, and the common prefix makes opening files within tracejit/ in an editor unnecessarily painful. I suggest jit-tests, other suggestions welcome. dmandelin mentioned the idea of merging the trace tests back with the jstests (in bug 602695 comment 2). We should rename trace_test.py accordingly (or merge it with jstests.py).

jit-tests is good. i'd like to keep them separate, since they complete faster, are easier to run solo, and have the nice --jitflags parameter.

(In reply to comment #1) > jit-tests is good. i'd like to keep them separate, since they complete faster, > are easier to run solo, and have the nice --jitflags parameter. Clarification: the intent would be to merge the driver programs, so that the new driver would have all the features of the old ones (bringing -j to jit-tests and --jitflags to jstests), while still allowing the suites to be run separately.

(In reply to comment #2) > > Clarification: the intent would be to merge the driver programs, so that the > new driver would have all the features of the old ones (bringing -j to > jit-tests and --jitflags to jstests), while still allowing the suites to be run > separately. That means this bug can just be about the renaming, and merging of the scripts can be a follow-up. Thanks for the clarification!

This patch renames "trace-test" as "jit-test" and "trace_test" as "jit_test" everywhere. Notable things: - The special cookie at the top of test files is now "|jit-test|". - The two copies of math-trace-tests.js were renamed to math-jit-tests.js. - I renamed tests/js1_8_1/trace/ as tests/js1_8_1/jit/. I checked I found everything by doing recursive greps for "trace-test" and "trace_test".

Comment on attachment 484596 [details] [diff] [review] patch (against TM 55696:51ca3657de5b) Side note: The bugzilla diff view didn't show the rename of trace_test.py properly: it showed the changes under the original name, and then at the bottom it showed the original file being deleted, with no new file added. Is this a known bug?

(In reply to comment #5) > > Side note: The bugzilla diff view didn't show the rename of trace_test.py > properly: it showed the changes under the original name, and then at the bottom > it showed the original file being deleted, with no new file added. Is this a > known bug? In the full text of the diff there is this: diff --git a/js/src/trace-test/trace_test.py b/js/src/jit-test/jit_test.py rename from js/src/trace-test/trace_test.py rename to js/src/jit-test/jit_test.py --- a/js/src/trace-test/trace_test.py +++ b/js/src/jit-test/jit_test.py <changes> I definitely used 'hg mv' to rename the file, I think it'll all work out ok.

(In reply to comment #6) > (In reply to comment #5) > > > > Side note: The bugzilla diff view didn't show the rename of trace_test.py > > properly: it showed the changes under the original name, and then at the bottom > > it showed the original file being deleted, with no new file added. Is this a > > known bug? > > In the full text of the diff there is this: > > diff --git a/js/src/trace-test/trace_test.py b/js/src/jit-test/jit_test.py > rename from js/src/trace-test/trace_test.py > rename to js/src/jit-test/jit_test.py > --- a/js/src/trace-test/trace_test.py > +++ b/js/src/jit-test/jit_test.py > <changes> > > I definitely used 'hg mv' to rename the file, I think it'll all work out ok. Oh yeah, your diff is fine. It looked weird in the bugzilla diff view so I clicked over to the raw view and saw that too. I guess I should file a bug on bugzilla, though.