Closed
Bug 605626
Opened 14 years ago
Closed 14 years ago
"ASSERTION: viewBox width must be greater than zero"
Categories
(Core :: SVG, defect)
Tracking
()
RESOLVED
FIXED
mozilla2.0b8
People
(Reporter: jruderman, Assigned: longsonr)
References
Details
(Keywords: assertion, testcase)
Attachments
(2 files, 2 obsolete files)
|
(deleted),
image/svg+xml
|
Details | |
|
(deleted),
patch
|
Details | Diff | Splinter Review |
testcase
###!!! ASSERTION: viewBox width must be greater than zero!: 'aViewboxWidth > 0', file layout/svg/base/src/nsSVGUtils.cpp, line 816
###!!! ASSERTION: viewBox height must be greater than zero!: 'aViewboxHeight > 0', file layout/svg/base/src/nsSVGUtils.cpp, line 817
|
Assignee | |
Comment 1•14 years ago
|
||
Assignee: nobody → longsonr
Attachment #485594 -
Flags: review?(dholbert)
|
||
Comment 2•14 years ago
|
||
Doesn't nsSVGImageFrame::GetFrameForPoint need an early return too, for zero image-native-size?
|
|
Assignee | |
Comment 3•14 years ago
|
||
Attachment #485594 -
Attachment is obsolete: true
Attachment #485603 -
Flags: review?(dholbert)
Attachment #485594 -
Flags: review?(dholbert)
|
|
Assignee | |
Comment 4•14 years ago
|
||
(In reply to comment #2)
> Doesn't nsSVGImageFrame::GetFrameForPoint need an early return too, for zero
> image-native-size?
yes it does :-)
|
|
||
Updated•14 years ago
|
Attachment #485603 -
Flags: review?(dholbert) → review+
|
|
Assignee | |
Comment 5•14 years ago
|
||
Comment on attachment 485603 [details] [diff] [review]
address review comment
Stops us asserting with images that can't be drawn. Low risk.
Attachment #485603 -
Flags: approval2.0?
Attachment #485603 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Comment 6•14 years ago
|
||
Attachment #485603 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [c-n: after 2.0b7 freeze]
|
||
Comment 7•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [c-n: after 2.0b7 freeze]
Target Milestone: --- → mozilla2.0b8
You need to log in
before you can comment on or make changes to this bug.
Description
•