Closed
Bug 605701
Opened 14 years ago
Closed 14 years ago
Make WIN32_REDIST_DIR support stricter and more explicit
Categories
(Firefox Build System :: General, defect)
Tracking
(status2.0 wontfix)
RESOLVED
FIXED
mozilla6
Tracking | Status | |
---|---|---|
status2.0 | --- | wontfix |
People
(Reporter: sgautherie, Assigned: sgautherie)
References
()
Details
Attachments
(3 files)
(deleted),
patch
|
benjamin
:
review+
benjamin
:
approval2.0-
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Callek
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
ted
:
review+
benjamin
:
approval2.0-
|
Details | Diff | Splinter Review |
Noticed these while working on some other bug.
Ftr,
*Tinderbox Opt builds usually have --enable-jemalloc thus don't care.
*Tinderbox Debug builds usually have (implicit) --disable-jemalloc thus care.
*User local builds have --disable-jemalloc by default thus may care.
Assignee | ||
Comment 1•14 years ago
|
||
*Make sure not to uselessly package the dlls when --enable-jemalloc.
*Error out if the path is invalid.
*Warn if not specified: not an error, just a reminder.
*Remove an obsolete "cygwin" while there.
Attachment #484609 -
Flags: review?(benjamin)
Assignee | ||
Comment 2•14 years ago
|
||
Attachment #484613 -
Flags: review?(bugspam.Callek)
Assignee | ||
Updated•14 years ago
|
Flags: in-testsuite-
Assignee | ||
Comment 3•14 years ago
|
||
Attachment #484615 -
Flags: review?(ted.mielczarek)
Updated•14 years ago
|
Attachment #484615 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 4•14 years ago
|
||
Comment on attachment 484615 [details] [diff] [review]
(Cv1-JS) Remove useless WIN32_REDIST_DIR support
[Checked in: Comment 9]
"approval2.0=?":
Useless configure code removal, no risk.
Attachment #484615 -
Flags: approval2.0?
Comment 5•14 years ago
|
||
Comment on attachment 484613 [details] [diff] [review]
(Bv1-CC) Remove useless WIN32_REDIST_DIR support
[Checked in: Comment 11]
please hold landing until patch C here lands.
Attachment #484613 -
Flags: review?(bugspam.Callek) → review+
Updated•14 years ago
|
Attachment #484615 -
Flags: approval2.0? → approval2.0-
Updated•14 years ago
|
Attachment #484609 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 6•14 years ago
|
||
Comment on attachment 484609 [details] [diff] [review]
(Av1) Just do it
[Checked in: See comment 8]
"approval2.0=?":
Some configure improvements, very low risk.
Attachment #484609 -
Flags: approval2.0?
Updated•14 years ago
|
Attachment #484609 -
Flags: approval2.0? → approval2.0-
Comment 7•14 years ago
|
||
This can land in the build-system branch.
Assignee | ||
Comment 8•14 years ago
|
||
Comment on attachment 484609 [details] [diff] [review]
(Av1) Just do it
[Checked in: See comment 8]
http://hg.mozilla.org/mozilla-central/rev/233c1426514f
Av1, unbitrotted.
Attachment #484609 -
Attachment description: (Av1) Just do it → (Av1) Just do it
[Checked in: See comment 8]
Assignee | ||
Comment 9•14 years ago
|
||
Comment on attachment 484615 [details] [diff] [review]
(Cv1-JS) Remove useless WIN32_REDIST_DIR support
[Checked in: Comment 9]
http://hg.mozilla.org/mozilla-central/rev/6da70394e0d5
Attachment #484615 -
Attachment description: (Cv1-JS) Remove useless WIN32_REDIST_DIR support → (Cv1-JS) Remove useless WIN32_REDIST_DIR support
[Checked in: Comment 9]
Assignee | ||
Comment 10•14 years ago
|
||
Patches A and C had succeeded as
http://tbpl.mozilla.org/?tree=MozillaTry&rev=54bf691c3326
Assignee | ||
Comment 11•14 years ago
|
||
Comment on attachment 484613 [details] [diff] [review]
(Bv1-CC) Remove useless WIN32_REDIST_DIR support
[Checked in: Comment 11]
http://hg.mozilla.org/comm-central/rev/a0f156172bc7
Attachment #484613 -
Attachment description: (Bv1-CC) Remove useless WIN32_REDIST_DIR support → (Bv1-CC) Remove useless WIN32_REDIST_DIR support
[Checked in: Comment 11]
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•