Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8pre) Gecko/20101020 Firefox/4.0b8pre ID:20101020042802 In Aero Basic, Window’s control button (minimize/maximize/close)is shifted to right side when right-clicking title bar.

Regression window: Works: http://hg.mozilla.org/mozilla-central/rev/599e710f7ace Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8pre) Gecko/20101019 Firefox/4.0b8pre ID:20101019111135 Fails: http://hg.mozilla.org/mozilla-central/rev/87b059ee9a67 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8pre) Gecko/20101019 Firefox/4.0b8pre ID:20101019130501 Pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=599e710f7ace&tochange=87b059ee9a67

Now this is an interesting fact: when you right click on the titlebar bringing the system menu, it seems that Windows draws its own caption buttons. As the system metrics from bug 601603 changed the positioning of these buttons, we can now see them shift. The fix is basically the same as for bug 605806 One thing to note: it appears that even before 601603 there was already a 1-pixel vertical shift that occured (I tested this with Aero Basic in win7, with a nightly build from Oct 16). We can address that in a later bug

I don't understand this patch, isn't any different from what you originally landed: https://bugzilla.mozilla.org/attachment.cgi?id=483042&action=diff

From what I understood: the -moz-appearance for the titlebar-buttonbox styles previously didn't have any effect, but now they're setting some width/height values and setting *aIsOverridable to false. The button positioning on the other themes (except aero glass) are done through the sizes/padding of each button itself, so 601603 introduced some extra dimensions that shifts them incorrectly.

Sorry!! the diff was in the wrong direction..

Comment on attachment 485130 [details] [diff] [review] Patch - for real That looks much better. Thanks.

Is the black space around the buttons (independent of the system menu causing them to shift to the right) a different bug?

sorry for the spam, I'd looked but not well enough. bug 605806 is for the black around caption buttons.