Closed
Bug 605935
Opened 14 years ago
Closed 14 years ago
Use private-browsing-transition-complete instead of sessionstore-browser-state-restored
Categories
(Firefox Graveyard :: Panorama, defect, P3)
Firefox Graveyard
Panorama
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: iangilman, Assigned: iangilman)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
ehsan.akhgari
:
review+
dietrich
:
approval2.0+
|
Details | Diff | Splinter Review |
From bug 604458:
(In reply to comment #12)
> As a side note, should we be observing private-browsing-transition-complete in
> our main PB handling code in tabview/ui.js? Right now we're observing
> private-browsing-change-granted, private-browsing, and
> sessionstore-browser-state-restored.
You should be observing private-browsing-transition-complete instead of
sessionstore-browser-state-restored. Please file a separate bug for that
though.
|
Assignee | |
Updated•14 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•14 years ago
|
||
No test needed, as it's just refactoring.
Attachment #487958 -
Flags: feedback?(ehsan)
|
||
Updated•14 years ago
|
Attachment #487958 -
Flags: feedback?(ehsan) → review+
|
|
Assignee | |
Updated•14 years ago
|
Attachment #487958 -
Flags: approval2.0?
|
||
Comment 3•14 years ago
|
||
Comment on attachment 487958 [details] [diff] [review]
patch v1
Then I'll approve it when that other patch gets checked in - please renominate then.
Attachment #487958 -
Flags: approval2.0? → approval2.0-
|
|
Assignee | |
Comment 4•14 years ago
|
||
It turns out this patch doesn't actually depend on bug 603721; I had built this on top of that, but in fact there is no overlap. Removing dependency.
|
||
Updated•14 years ago
|
Attachment #487958 -
Flags: approval2.0- → approval2.0+
|
|
Assignee | |
Comment 6•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•9 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•