follow up from bug 570275 bz: May be worth a followup bug to add the accessibility service to the service cache... surkvo: we keep accessibiltiy service instance in cache in a11y and return it when we were asked, but if this is going to speed up things then it's worth to do. bz: Yeah; it'll avoid going through the service manager at all to get the service..

note, bug 628922 makes layout to use the accessibility service cached in a11y. For other places that should start accessibility if necessary then accessibility service manager should be used, it's worth to fix this bug for these cases (for that you need to fix xpcom/build/ServiceList.h, Service.cpp files)

Comment on attachment 541985 [details] [diff] [review] bug 606085 - add accessibility service to service list in xpcom/build/ServiceList.h I'm not sure if there's supposed to be an ordering to the expandos / includes.

Comment on attachment 541985 [details] [diff] [review] bug 606085 - add accessibility service to service list in xpcom/build/ServiceList.h Review of attachment 541985 [details] [diff] [review]: ----------------------------------------------------------------- no my review is needed in this case (no a11y code is changed and iirc no a11y related code is affected)

Comment on attachment 541985 [details] [diff] [review] bug 606085 - add accessibility service to service list in xpcom/build/ServiceList.h All the other services use InitialCaps, please follow that convention. r=me with that change.

correct capatolization, I hadn't noticed that.

FYI, mozilla-central is burning.... this fixed it in my tree.

Comment on attachment 543089 [details] [diff] [review] bustage fix Thanks, yes this looks fine!

Pushed the bustage fix: http://hg.mozilla.org/mozilla-central/rev/2a75e12a105a

(In reply to comment #7) > Created attachment 543089 [details] [diff] [review] [review] > bustage fix > > FYI, mozilla-central is burning.... this fixed it in my tree. dam, yeah we need that ifdef.