JavaScript strict warning: chrome://communicator/content/pref/pref-fonts.js line 80: redeclaration of var prefvalue JavaScript strict warning: chrome://communicator/content/pref/pref-fonts.js line 89: redeclaration of var prefvalue JavaScript strict warning: chrome://communicator/content/pref/pref-fonts.js line 7: assignment to undeclared variable fonts JavaScript strict warning: chrome://communicator/content/pref/pref-fonts.js line 50: reference to undefined property aDataObject.languageData JavaScript strict warning: chrome://communicator/content/pref/pref-fonts.js line 51: reference to undefined property aDataObject.currentLanguage JavaScript strict warning: chrome://communicator/content/pref/pref-fonts.js line 57: reference to undefined property aDataObject.dataEls JavaScript strict warning: chrome://communicator/content/pref/pref-fonts.js line 57: reference to undefined property aDataObject.dataEls JavaScript strict warning: chrome://communicator/content/pref/pref-fonts.js line 76: reference to undefined property aDataObject.fontDPI JavaScript strict warning: chrome://communicator/content/pref/pref-fonts.js line 85: reference to undefined property aDataObject.useDocFonts JavaScript strict warning: chrome://communicator/content/pref/pref-fonts.js line 139: assignment to undecla red variable faces JavaScript strict warning: chrome://communicator/content/pref/pref-fonts.js line 156: assignment to undecla red variable gNoFontsForThisLang JavaScript strict warning: chrome://communicator/content/pref/pref-fonts.js line 273: reference to undefine d property languageData[languageList.data] JavaScript strict warning: chrome://communicator/content/pref/pref-fonts.js line 273: reference to undefine d property languageData[languageList.data] JavaScript strict warning: chrome://communicator/content/pref/pref-fonts.js line 273: reference to undefine d property languageData[languageList.data] JavaScript strict warning: chrome://communicator/content/pref/pref-fonts.js line 30: reference to undefined property dataObject.dataEls JavaScript strict warning: chrome://communicator/content/pref/pref-fonts.js line 240: reference to undefine d property languageData[currentLanguage] JavaScript strict warning: chrome://communicator/content/pref/pref-fonts.js line 242: reference to undefine d property languageData[currentLanguage].types

I don't see any strict warnings anymore (with javascript.options.strict on), the errors seems to have been fixed ( I checked every one of them)

Hmmm... I dont know you you concluded this one was fixed but: Warning: redeclaration of var prefvalue Source File: chrome://communicator/content/pref/pref-fonts.js Line: 92, Column: 20 Warning: redeclaration of var defaultListSelection Source File: chrome://communicator/content/pref/pref-fonts.js Line: 344, Column: 12 Warning: redeclaration of var selectedItem Source File: chrome://communicator/content/pref/pref-fonts.js Line: 374, Column: 20 Warning: reference to undefined property aDataObject.languageData Source File: chrome://communicator/content/pref/pref-fonts.js Line: 72 Warning: reference to undefined property aDataObject.dataEls Source File: chrome://communicator/content/pref/pref-fonts.js Line: 81 Warning: reference to undefined property aDataObject.fontDPI Source File: chrome://communicator/content/pref/pref-fonts.js Line: 102 Warning: reference to undefined property aDataObject.useDocFonts Source File: chrome://communicator/content/pref/pref-fonts.js Line: 135 Warning: reference to undefined property languageData[languageList.value] Source File: chrome://communicator/content/pref/pref-fonts.js Line: 346

Sorry about that, for some reason moz didn't pickup my user.js. Since I'm here, I'll try to create a patch to get rid of the warnings, though this is a small problem compared to the many other warnings I'm getting from other js files.

please make the diff output: diff -u

Still getting (now also js error...): Warning: redeclaration of var prefvalue Source File: chrome://communicator/content/pref/pref-fonts.js Line: 92, Column: 20 Warning: redeclaration of var defaultListSelection Source File: chrome://communicator/content/pref/pref-fonts.js Line: 344, Column: 12 Warning: redeclaration of var selectedItem Source File: chrome://communicator/content/pref/pref-fonts.js Line: 374, Column: 20 Warning: reference to undefined property aDataObject.useDocFonts Source File: chrome://communicator/content/pref/pref-fonts.js Line: 135 Warning: reference to undefined property languageData[currentLanguage] Source File: chrome://communicator/content/pref/pref-fonts.js Line: 309 Error: invalid 'in' operand currentLanguage Source File: chrome://communicator/content/pref/pref-fonts.js Line: 309

Much better, but: Warning: assignment to undeclared variable calscreen Source File: chrome://communicator/content/pref/pref-fonts.js Line: 433

Taking to checkin for basic.

basic, Can you drive the review process? I'll check it in for you once this is r'd and sr'd. Thanks.

I can check this in once it is reviewed.

This bug has not been touched in over three months; by now, basic's patch has probably bit-rotted. Anyone care to make progress on this thing?

I'll fix the warnings with my patch for bug 110342 (not yet attached there)

I decided to *not* fix it as part of 110342.

With the attached patch, the only warning I'm seeing is: Warning: reference to undefined property screenResolution.getElementsByAttribute("value", resolution)[0] Source File: chrome://communicator/content/pref/pref-fonts.js Line: 517

Comment on attachment 75783 [details] [diff] [review] updated patch r=caillon for the changes, though it would be nice to also get that last warning fixed...

Comment on attachment 75783 [details] [diff] [review] updated patch sr=shaver, though the (existing) stylistic inconsistencies grate.

Comment on attachment 80248 [details] [diff] [review] Patch for the last case r=caillon

Comment on attachment 80285 [details] [diff] [review] Fixed double-spacing sr=shaver.

aren't these patches already checked in so that this can be marked fixed?

marking fixed. caillon checked in the patch for me.

vrfy'd fixed using 2002.06.17.08 comm trunk bits (linux rh7.2).