Closed
Bug 606592
Opened 14 years ago
Closed 14 years ago
Make nsExceptionService practice safe refcounting
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla5
People
(Reporter: jdm, Assigned: jdm)
References
Details
Attachments
(1 file)
(deleted),
patch
|
jst
:
review+
joe
:
approval2.0-
|
Details | Diff | Splinter Review |
From bug 508128, comment 84:
>I talked to jst about this, and he sounded ok with just making the reference counting threadsafe in this case.
>
>http://hg.mozilla.org/mozilla-central/file/3a5b84a290d7/xpcom/base/nsExceptionService.cpp#l95
>already documents that it can be released on a different thread during shutdown.
Assignee | ||
Comment 1•14 years ago
|
||
Assignee | ||
Updated•14 years ago
|
Attachment #485418 -
Flags: review?(jst)
Assignee | ||
Comment 2•14 years ago
|
||
This patch makes the failures in bug 508128 disappear.
Updated•14 years ago
|
Attachment #485418 -
Flags: review?(jst) → review+
Assignee | ||
Comment 3•14 years ago
|
||
Comment on attachment 485418 [details] [diff] [review]
Make nsExceptionService practice threadsafe refcounting.
This is needed to land bug 508128, which is a righteous goal.
Attachment #485418 -
Flags: approval2.0?
Updated•14 years ago
|
Attachment #485418 -
Flags: approval2.0? → approval2.0+
Isn't this the same problem that we ran into when trying to move WeaveCrypto off the main thread? The real problem is that nsExeceptionService shuts down too early. This might make the asserts go away, but what happens if we trigger an exception after the nsExceptionService is dead?
Comment 5•14 years ago
|
||
Comment on attachment 485418 [details] [diff] [review]
Make nsExceptionService practice threadsafe refcounting.
Looks like this was never landed. It can't land now.
Attachment #485418 -
Flags: approval2.0+ → approval2.0-
Comment 6•14 years ago
|
||
Is this about nsExceptionManager or nsExceptionService?
Comment 7•14 years ago
|
||
Assignee: nobody → josh
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2
Assignee | ||
Comment 8•14 years ago
|
||
Hmm, I never ended up deciding whether this patch or the one in bug 450812 would be the better choice. I guess we can always back out in the future.
Assignee | ||
Updated•14 years ago
|
Comment 9•14 years ago
|
||
(In reply to comment #8)
> Hmm, I never ended up deciding whether this patch or the one in bug 450812
> would be the better choice. I guess we can always back out in the future.
Yes, let me know if you want me to backout, please, and sorry for stepping on your toes.
You need to log in
before you can comment on or make changes to this bug.
Description
•