Closed
Bug 606691
Opened 14 years ago
Closed 14 years ago
combined location bar buttons should not appear in popups without toolbar items
Categories
(Firefox :: General, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: alice0775, Assigned: fryn)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
dao
:
review+
Gavin
:
approval2.0+
|
Details | Diff | Splinter Review |
Build Identifier:
http://hg.mozilla.org/mozilla-central/rev/092596c1faef
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8pre) Gecko/20101022 Firefox/4.0b8pre ID:20101023101209
STR: Load attachment 464766 [details], open the popup, Middle-click the reload button.
A non-visible tab generated.
The following error shows in error console.
Error: newBrowser is undefined
Source file: chrome://browser/content/tabbrowser.xml
Line: 754
var updatePageReport = false;
if (!oldBrowser ||
(oldBrowser.pageReport && !newBrowser.pageReport) ||
>> (!oldBrowser.pageReport && newBrowser.pageReport))
updatePageReport = true;
Error: content is null
Source file: chrome://browser/content/browser.js
Line: 5313
function pageShowEventHandlers(event) {
// Filter out events that are not about the document load we are interested in
>> if (event.originalTarget == content.document) {
charsetLoadListener(event);
XULBrowserWindow.asyncUpdateUI();
}
}
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → fryn
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•14 years ago
|
||
this removes the integrated buttons from those types of popups, as per dao's comment.
Attachment #486963 -
Flags: review?(dao)
|
||
Updated•14 years ago
|
Attachment #486963 -
Flags: review?(dao) → review+
|
||
Updated•14 years ago
|
Attachment #486963 -
Flags: approval2.0+
|
|
Assignee | |
Updated•14 years ago
|
Summary: Middle-click the reload button shouldn't add tabs to popups → combined location bar buttons should not appear in popups without toolbar items
|
|
Assignee | |
Comment 3•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•