Closed Bug 606744 Opened 14 years ago Closed 13 years ago

Enter/Exit Panorama button alignment

Categories

(Firefox Graveyard :: Panorama, defect, P2)

All
Windows XP

Tracking

(Not tracked)

RESOLVED WONTFIX
Future

People

(Reporter: mgway12, Unassigned)

References

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8pre) Gecko/20101024 Firefox/4.0b8pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8pre) Gecko/20101024 Firefox/4.0b8pre

A little issue that drives me crazy, the enter/exit buttons for panorama view don't line up. I'm pretty sure this problem originated a while ago when the tab list dropdown arrow was on the left side of enter button, whereas now it is on the right side. 

A fix would be easy enough, I did so myself by just adding padding-left: 15px; to #exit-button in tabview.css (I'll add the patch as an attachment)

Also, as a rider on this bug report, I think it would be useful to consider placing app tab icons along the right side panorama view, starting underneath the search icon. 

Reproducible: Always

Steps to Reproduce:
1. Click on the panorama button to enter panorama mode
2. Move the mouse 10px to the right to exit panorama mode
Blocks: 598154
OS: Windows 7 → Windows XP
Priority: -- → P2
Attachment #485565 - Flags: review?(ian)
I'm not sure what's going on upstream about the location of the 'list all tabs' dropdown arrow. This dinky little fix was for when the arrow was on the right of the panorama button, but it appears to have jumped back to the left side of the panorama button. 

So, if the panorama button is now in its final resting place, this is resolved.
The Panorama button and List all tabs button would be combined together. See Bug 596017
Depends on: 596017
(In reply to comment #4)
> The Panorama button and List all tabs button would be combined together. See
> Bug 596017

Raymond, would you say bug 596017 makes this bug obsolete?
I have a similar bug but not the same : tell me if i have to open a different bug.
On Linux (Ubuntu 10.10 64 bits) with menu bar displayed (=default mode on Linux in Firefox 4) panorama button moves up and down depending if Panorama mode is ON or OFF.
I always have to move the mouse up and down to enter/exit the panorama mode.
If menu bar is hidden, panorama button doesn't move.
bugspam (moving b9 to b10)
Blocks: 608028
bugspam (removing b9)
No longer blocks: 598154
Depends on: 624138
Punt
No longer blocks: 608028
Target Milestone: --- → Future
Note bug 596017 will not happen for fx4.
Matthew, sorry this seems to have been left behind. Is this still an issue that your patch will help with?
Version: unspecified → Trunk
Thanks for your patch but we will implement bug 630792 in the near future.
Status: UNCONFIRMED → RESOLVED
Closed: 13 years ago
Resolution: --- → WONTFIX
Attachment #485565 - Flags: review?(ian)
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: