Closed
Bug 607566
Opened 14 years ago
Closed 14 years ago
Test for bug 595930 takes too long to run
Categories
(Firefox Graveyard :: Panorama, defect, P2)
Firefox Graveyard
Panorama
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 4.0b8
People
(Reporter: raymondlee, Assigned: raymondlee)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file, 4 obsolete files)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
The browser_tabview_bug595930 takes too long to run because it waits until the group item is closed (including 15seconds for the undo group button to dismiss). We should speed it up by setting groupItem.fadeAwayUndoButtonDelay and groupItem.fadeAwayUndoButtonDuration but we need to wait until patch for bug 595521 to land first.
|
Assignee | |
Updated•14 years ago
|
|
|
Assignee | |
Updated•14 years ago
|
Priority: -- → P2
|
|
Assignee | |
Comment 1•14 years ago
|
||
(In reply to comment #0)
> The browser_tabview_bug595930 takes too long to run because it waits until the
> group item is closed (including 15seconds for the undo group button to
> dismiss). We should speed it up by setting groupItem.fadeAwayUndoButtonDelay
> and groupItem.fadeAwayUndoButtonDuration but we need to wait until patch for
> bug 595521 to land first.
Ignore the above please. The problem is that the ctrl+e is used before the group is ready. The patch fixes the problem. Sent it to try.
|
|
Assignee | |
Comment 2•14 years ago
|
||
Attachment #486326 -
Flags: feedback?(ian)
|
|
Assignee | |
Updated•14 years ago
|
Attachment #486326 -
Attachment is patch: true
Attachment #486326 -
Attachment mime type: application/octet-stream → text/plain
|
||
Comment 3•14 years ago
|
||
s/appriopate/appropriate/
|
|
Assignee | |
Comment 4•14 years ago
|
||
Fixed a typo
Attachment #486326 -
Attachment is obsolete: true
Attachment #486329 -
Flags: feedback?(ian)
Attachment #486326 -
Flags: feedback?(ian)
|
|
Assignee | |
Updated•14 years ago
|
Status: NEW → ASSIGNED
|
||
Comment 5•14 years ago
|
||
Comment on attachment 486329 [details] [diff] [review]
v1
Perhaps you could put a little more detail in the comments in the code about why you need the delay? Otherwise looks good.
Attachment #486329 -
Flags: feedback?(ian) → feedback+
|
|
Assignee | |
Comment 6•14 years ago
|
||
f=ian. Updated the comment.
Attachment #486329 -
Attachment is obsolete: true
Attachment #486558 -
Flags: review?(dolske)
|
|
||
Updated•14 years ago
|
Attachment #486558 -
Flags: review?(dolske)
Attachment #486558 -
Flags: review+
Attachment #486558 -
Flags: approval2.0?
|
|
Assignee | |
Comment 7•14 years ago
|
||
Sent it to try 301a9cc7f739, waiting for the result
r=ian
Attachment #486558 -
Attachment is obsolete: true
Attachment #490774 -
Flags: approval2.0?
Attachment #486558 -
Flags: approval2.0?
|
|
Assignee | |
Comment 8•14 years ago
|
||
(In reply to comment #7)
> Created attachment 490774 [details] [diff] [review]
> v1
>
> Sent it to try 301a9cc7f739, waiting for the result
>
> r=ian
Passed try
|
||
Comment 9•14 years ago
|
||
Comment on attachment 490774 [details] [diff] [review]
v1
a=beltzner, good test-driven bug!
Attachment #490774 -
Flags: approval2.0? → approval2.0+
|
|
Assignee | |
Comment 10•14 years ago
|
||
Attachment #490774 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Updated•14 years ago
|
Attachment #492710 -
Attachment is patch: true
Attachment #492710 -
Attachment mime type: application/octet-stream → text/plain
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
||
Comment 12•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b8
|
||
Updated•14 years ago
|
Whiteboard: [qa-]
|
||
Updated•9 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•