Closed Bug 60768 Opened 24 years ago Closed 17 years ago

Move URL fixup code out of webshell

Categories

(Core :: DOM: Navigation, defect, P3)

defect

Tracking

()

VERIFIED DUPLICATE of bug 109309

People

(Reporter: adamlock, Assigned: rpotts)

References

Details

If the site http://somewebsite/ does not exist, the webshell will fix it up to http://www.somewebsite.com/ and trying loading that. The webshell also has some keyword fixup code. This could all be moved into the new URI fixup service.
Is this related to bug 34943, "automatic www. and .com [etc] shouldn't happen on links"?
Yes it's related though this bug deals where rather than when it should happen. I'll add a dependency between this bug and the other one.
Blocks: 34943
Who is doing this service?
The fixup services is in the docshell module. It already does pre-browsing fixup, i.e. turning www.blah.com into http://www.blah.com, but it doesn't do the post-fixup after the first URL fails. This code currently resides in the webshell and should be moved out.
Target Milestone: --- → mozilla0.9
Adam, thanks for the information. My question was, which person will do the new service. Is that job already assigned? I have put some notes on various bugs that outline some of the things I think this service should do and would like to discuss my ideas.
Reassigning to Rick Potts who is writing a patch to move post-load fixup from webshell into this service. Here is the link to the default fixup object as it is now: http://lxr.mozilla.org/seamonkey/source/docshell/base/nsDefaultURIFixup.cpp Now the fixup is done by a service it can be replaced or extended without screwing around with the docshell.
Assignee: adamlock → rpotts
Blocks: 63736
This bug blocks a potential security hole (bug 34943), so nominating for nsbeta1.
Target Milestone: mozilla0.9 → mozilla0.9.1
Target Milestone: mozilla0.9.1 → mozilla1.0
OS: Windows 2000 → All
Hardware: PC → All
Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 (you can query for this string to delete spam or retrieve the list of bugs I've moved)
Target Milestone: mozilla1.0 → mozilla1.0.1
retargeting
Target Milestone: mozilla1.0.1 → Future
Please don't "Future" bugs that you don't own.
Target Milestone: Future → ---
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → DUPLICATE
V/dupe.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.