Closed
Bug 608498
Opened 14 years ago
Closed 14 years ago
Turn on fakelibs on Android
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 584474
People
(Reporter: mwu, Unassigned)
References
Details
Attachments
(1 file)
(deleted),
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
This may be necessary for some work I want to do.
You might be interested in glandium's patches in Bug 584474.
Reporter | ||
Comment 2•14 years ago
|
||
Seems to work. A little messy because android needs to be detected by OS_TARGET.
Attachment #489985 -
Flags: review?(khuey)
Comment on attachment 489985 [details] [diff] [review]
Turn on fakelibs on android
Assuming this actually works, r=me. ;-)
Attachment #489985 -
Flags: review?(khuey) → review+
Reporter | ||
Updated•14 years ago
|
Attachment #489985 -
Flags: approval2.0?
Comment 4•14 years ago
|
||
what is the testing situation for fakelibs? how can we be sure this doesn't regress anything?
Reporter | ||
Comment 5•14 years ago
|
||
(In reply to comment #4)
> what is the testing situation for fakelibs? how can we be sure this doesn't
> regress anything?
I've been using it for the last few days and it seems to work fine. Requesting approval now so we can get additional testing in the nightlies. I'm not sure what sort of regressions fakelibs could introduce.
If it builds you should be fine. We didn't have any fallout on Windows on m-c other than build/linkage errors.
Reporter | ||
Comment 7•14 years ago
|
||
Yeah, I'd expect the problems to all show up at build time. There could be problems with symbol collisions or something but those directories shouldn't have fakelibs turned on.
Comment 8•14 years ago
|
||
Comment on attachment 489985 [details] [diff] [review]
Turn on fakelibs on android
a=blassey
Attachment #489985 -
Flags: approval2.0? → approval2.0+
Reporter | ||
Comment 9•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment 10•14 years ago
|
||
backed out per mwu's request http://hg.mozilla.org/mozilla-central/rev/829307640234
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Reporter | ||
Comment 11•14 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Mobile/1289946979.1289951119.31415.gz&fulltext=1
make[5]: execvp: /tools/android-ndk/build/prebuilt/linux-x86/arm-eabi-4.4.0/bin/arm-eabi-ar: Argument list too long
make[5]: *** [libgklayout.a] Error 127
make[5]: Leaving directory `/builds/slave/mozilla-central-mobile-browser-android-r7-build/build/mozilla-central/objdir/layout/build'
Apparently the systems we're building on are ancient and probably don't have support for unlimited length arg lists. Not sure why this would trigger with fakelibs on.. didn't we have pretty long lists of objects to link before?
For some reason you're getting absolute paths passed to ar. That's almost certainly what's killing you.
Updated•14 years ago
|
Attachment #489985 -
Flags: approval2.0+
Comment 14•14 years ago
|
||
Did bug 584474 fix this?
Subsumed, perhaps.
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → DUPLICATE
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•