Discovered as a failure in MozMill test, raised as bug 605554. To replicate: 1. Set the full keyboard access in System Preferences > Keyboard to 'Text boxes and lists only' 2. Start Firefox, and open a page with a different URL to the home page 3. Open Preferences dialog 4. Click 'Set to Current Page' under home page preference 5. Hit ESCAPE key 6. Open Preferences dialog Expected: Home Page URL should be new value Actual: Home Page URL is the previous (old) value I managed to trace this back to the nightly build on 04/22/2010. Check-ins between last good and first bad: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=cdc8bf25220e&tochange=ab4c6ba5ff70 Henrik picked up on the Keyboard setting, and we're now able to replicate this reliably on multiple machines.

So given the pushlog this should be clearly a regression from: Bug 418521, improve the way focus indicators are displayed to correlate better with system behaviour, add -moz-focusring property to apply only when focus rings should be drawn, r=dao,jmathies,dbaron sr=neil Asking for blocking 2.0, because changes in a dialog aren't saved immediately anymore on OS X.

Not a regression from that bug. You'll find the same behaviour in any older build if you focus the home page field, press the button, then press Escape.

(In reply to comment #2) > Not a regression from that bug. You'll find the same behaviour in any older > build if you focus the home page field, press the button, then press Escape. Neil, this is clearly a regression between the builds 100421 and 100422 on trunk. If it's not a regression from bug 605554 there should be another patch in the above pushlog which is causing this regression. This bug is NOT visible in builds on older branches (1.9.2 and 1.9.1). Both settings for full keyboard access are working in those cases.

And we can proof this by the results of our Mozmill tests. Those are only failing on trunk but not 1.9.2 nor 1.9.1.

OK, well, fixing bug 418521 revealed this underlying bug then.

(In reply to comment #6) > OK, well, fixing bug 418521 revealed this underlying bug then. Same shows an hg bisect: The first bad revision is: changeset: 41071:f3abfe490d7f user: Neil Deakin <neil@mozilla.com> date: Wed Apr 21 10:53:42 2010 -0400 summary: Bug 418521, improve the way focus indicators are displayed to correlate better with system behaviour, add -moz-focusring property to apply only when focus rings should be drawn, r=dao,jmathies,dbaron sr=neil As given by Neil over on bug 576337: The Escape key here is reverting the textbox value and closing the dialog. When the button is pressed, the revertability of the textbox should be cleared somehow. Neil, that means it is a widget issue and not a navigation one?

This sounds like a preference dialog bug to me.

Taking, as I fixed this few years ago...

I get that it's a regression, but I don't think it's worth blocking on.

Mano, do you have an update?

This bug has been tagged for regression and or closure. I cannot produce the error in Nightly or Release (49.0a1 / 46.0.1) Mac OS X 01.11; If anyone can still reproduce it, feel free to reopen the issue and provide updated steps/links.