Closed
Bug 609744
Opened 14 years ago
Closed 14 years ago
Make the web console control-e terminal keybinding play nicely with Panorama
Categories
(DevTools :: General, defect, P1)
Tracking
(blocking2.0 -)
RESOLVED
INVALID
Tracking | Status | |
---|---|---|
blocking2.0 | --- | - |
People
(Reporter: ddahl, Assigned: ddahl)
References
Details
I think we can temporarily override Panorama's key command while the web console is open (or the input is focused), releasing control-e when the terminal input is not focused.
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → ddahl
Assignee | ||
Updated•14 years ago
|
blocking2.0: --- → ?
Updated•14 years ago
|
Assignee: ddahl → nobody
Priority: -- → P3
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → ddahl
Assignee | ||
Comment 2•14 years ago
|
||
This should block as this is something of a regression, we currently have control-a activated in each terminal input but not control-e. This is a developer ergonomics issue as well.
Priority: P3 → --
Comment 3•14 years ago
|
||
I hit this all the time on windows and it's incredibly jarring.
I think we could add a focus listener to the input line to transplant the key-command and return it when we leave pretty easily.
Assignee | ||
Comment 4•14 years ago
|
||
(In reply to comment #3)
> I hit this all the time on windows and it's incredibly jarring.
>
> I think we could add a focus listener to the input line to transplant the
> key-command and return it when we leave pretty easily.
ok, cool. I will try that route - I should be able to look at this this week. It is jarring.
Updated•14 years ago
|
Priority: -- → P1
Assignee | ||
Comment 5•14 years ago
|
||
(In reply to comment #3)
> I think we could add a focus listener to the input line to transplant the
> key-command and return it when we leave pretty easily.
the current eventHandler (JSTerm.keyDown) -that fails - is here: http://mxr.mozilla.org/mozilla-central/source/toolkit/components/console/hudservice/HUDService.jsm#4254
Rob:
Can you point me to a focus listener I can crib from? Does it use the focusManager in some way?
Comment 6•14 years ago
|
||
nothing so complex. See:
http://mxr.mozilla.org/mozilla-central/source/widget/tests/window_composition_text_querycontent.xul#22
You could add a corresponding onblur event that unmaps the key override.
to fit with the way we init the JSTerm object in:
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/console/hudservice/HUDService.jsm#3944
I'd try adding:
this.inputNode.addEventListener('focus', remapCtrlE, false);
this.inputNode.addEventListener('blur', remapCtrlE, false);
or similar. Might want to wrap all that in an #ifndef MAC_OS_X block to hide it there since it's unneeded. Or something. :)
Comment 7•14 years ago
|
||
This is not a release blocker. Would approve a safe patch.
blocking2.0: ? → -
Assignee | ||
Comment 8•14 years ago
|
||
note: Panorama sets a window listener here: http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser-tabview.js#240 (in _setBrowserKeyHandlers)
Comment 9•14 years ago
|
||
Panorama's shortcut was changed to shift+ctrl+E. David, should this be closed invalid now?
Assignee | ||
Comment 10•14 years ago
|
||
bug 634588 made this invalid
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → INVALID
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•