Closed
Bug 609952
Opened 14 years ago
Closed 14 years ago
Move sendToWebConsole functionality from ConsoleAPIObserver to HUDService
Categories
(DevTools :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 4.0b8
People
(Reporter: ddahl, Assigned: Gavin)
References
Details
(Whiteboard: [followup])
Attachments
(1 file)
|
(deleted),
patch
|
ddahl
:
review+
beltzner
:
approval2.0+
|
Details | Diff | Splinter Review |
followup from gavin's review of bug 587734:
> >+ function CAO_sendToWebConsole(aWebConsole, aLevel, aArguments)
>
> And this method seems like it reaches into HUDService/aWebConsole a bit too
> much - seems like there should be a HUDService.logConsoleMessage(aHudID,
> aLevel, aArguments) that contains most of this code (the existing
> logConsoleMessage seems unused).
|
Reporter | |
Updated•14 years ago
|
Assignee: nobody → ddahl
Whiteboard: [followup]
|
Assignee | |
Comment 1•14 years ago
|
||
This is on top of the patch for bug 609950.
Attachment #491073 -
Flags: review?(ddahl)
|
|
Assignee | |
Updated•14 years ago
|
Assignee: ddahl → gavin.sharp
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•14 years ago
|
||
Oh, and both patches are on top of the patch for bug 580618.
|
|
Reporter | |
Comment 3•14 years ago
|
||
Comment on attachment 491073 [details] [diff] [review]
patch
>- * logs a message to the Heads Up Display that originates
>- * in the nsIConsoleService
>+ * Logs a message to the Heads Up Display that originates
>+ * in the from the window.console API
nit: remove "in the" from comment
Attachment #491073 -
Flags: review?(ddahl) → review+
|
||
Comment 4•14 years ago
|
||
Comment on attachment 491073 [details] [diff] [review]
patch
a=beltzner
Attachment #491073 -
Flags: approval2.0+
|
|
Assignee | |
Comment 5•14 years ago
|
||
Landed with that change https://hg.mozilla.org/mozilla-central/rev/6e4659bdc601
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b8
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•