Closed
Bug 610609
Opened 14 years ago
Closed 14 years ago
The console's logging API is disabled after closing and re-opening the console UI
Categories
(DevTools :: General, defect, P1)
Tracking
(blocking2.0 betaN+)
RESOLVED
WORKSFORME
Tracking | Status | |
---|---|---|
blocking2.0 | --- | betaN+ |
People
(Reporter: vladmaniac, Assigned: msucan)
References
Details
Build ID:
Mozilla/5.0 (Windows NT 6.1; rv:2.0b8pre) Gecko/20101107 Firefox/4.0b8pre
Reproducible also with Fx4b7 candidates.
=========================================================================
Steps:
1. Open www.digg.com (this can be a page of your choice)
2. Open console
3. Toggle in fullscreen mode (F11)
4. Close console
5. Open again
=========================================================================
Behavior:
Console echoes
11:15:27.862: The Web Console logging API (console.log, console.info, console.warn, console.error) has been disabled by a script on this page.
Comment 1•14 years ago
|
||
I can reproduce that without going into full-screen mode. After a reload the console object is gone. Sounds like we need a mochitest for this. This is a regression for sure.
Comment 2•14 years ago
|
||
Is the lazy console API likely to change the behavior at all for this?
Assignee: nobody → mihai.sucan
Blocks: devtools4
Comment 3•14 years ago
|
||
(In reply to comment #2)
> Is the lazy console API likely to change the behavior at all for this?
It does change the way we test for the console object - as an instance of Ci.nsIConsoleAPI - which will change further once a patch is created for bug 609955
There will be impact.
Updated•14 years ago
|
Summary: The console's logging API is disabled after toggling fullscreen mode → The console's logging API is disabled after closing and re-opening the console UI
Assignee | ||
Comment 4•14 years ago
|
||
Checked the code we currently have:
The problem is in unregisterDisplay() where we check if aContentWindow.wrappedJSObject.console instanceof HUDConsole. The check returns false, thus we do not delete the console object from the web page.
Next time when the Web Console is open, it finds the old console object, and complains.
Weird thing is: console.constructor === HUDConsole also fails. (constructor is undefined). Is this compartments landing fun?
I know that this stuff used to work, and constructor === HUDConsole also worked in some other builds I had, since compartments landed.
Somehow, I expect this will still fail once the lazy console stuff lands.
Comment 5•14 years ago
|
||
OK, thanks for the investigation, Mihai.
I'm going to request blocking on this because we can't ship the feature with this problem. If we're lucky, the lazy console work will just fix this, but we'll want this bug to track it and make sure.
blocking2.0: --- → ?
Updated•14 years ago
|
blocking2.0: ? → betaN+
Comment 8•14 years ago
|
||
Lazy console has landed. we should check the status of this.
Comment 9•14 years ago
|
||
fixed by bug 587734
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → WORKSFORME
Reporter | ||
Comment 10•14 years ago
|
||
Build ID:
Mozilla/5.0 (Windows NT 6.1; rv:2.0b10pre) Gecko/20110120 Firefox/4.0b10pre
when navigating to http://cnn.com this error reappears. It seems like only http://cnn.com triggers the script that blocks the console logging API.
This is not happening on Safari.
Are we letting cnn to block the console's logging API?
Assignee | ||
Comment 11•14 years ago
|
||
(In reply to comment #10)
> Build ID:
>
> Mozilla/5.0 (Windows NT 6.1; rv:2.0b10pre) Gecko/20110120 Firefox/4.0b10pre
>
> when navigating to http://cnn.com this error reappears. It seems like only
> http://cnn.com triggers the script that blocks the console logging API.
> This is not happening on Safari.
>
> Are we letting cnn to block the console's logging API?
Yes, that is known.
CNN.com and other web sites define their own window.console object. We do not overwrite the window.console object, and the warning tells that.
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•