Closed
Bug 611044
Opened 14 years ago
Closed 14 years ago
Add compartment checks before and after debug hook calls
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: jorendorff, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
Inspired by bug 610973, though they probably wouldn't have caught that bug any earlier. Anyway, there's no point in not having these assertions.
Attachment #489527 -
Flags: review?(mrbkap)
Reporter | ||
Comment 1•14 years ago
|
||
Review ping.
Note that this patch isn't trying to pin the JSDBGAPI to down any kind of scary compartmentally strict contracts that might assert all over the place. Rather, these assertions are enforcing some very basic, obvious aspects of the contracts of the JSDBGAPI *callbacks*; if they trip, it's definitely a serious bug.
Comment 2•14 years ago
|
||
Comment on attachment 489527 [details] [diff] [review]
v1
Have you tried this patch with Firebug on? It might be worth doing at least a very basic smoketest to make sure this isn't going to entirely break debug builds with Firebug enabled.
Sorry for the delay.
Attachment #489527 -
Flags: review?(mrbkap) → review+
Updated•14 years ago
|
Assignee: general → nobody
Component: JavaScript Engine → JavaScript Debugging APIs
QA Contact: general → jsd
Reporter | ||
Comment 3•14 years ago
|
||
->WONTFIX.
I don't want to risk breaking something and wasting hours of somebody's time. JSD2's callbacks will just be JS functions, so we'll get the benefit of the existing assertions (in CallJSNative and all over the place).
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → WONTFIX
Assignee | ||
Updated•13 years ago
|
Component: JavaScript Debugging/Profiling APIs → JavaScript Engine
You need to log in
before you can comment on or make changes to this bug.
Description
•