Closed
Bug 613131
Opened 14 years ago
Closed 14 years ago
role nothing should allow recursive name calculation from children
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla2.0b8
People
(Reporter: surkov, Assigned: surkov)
References
(Blocks 1 open bug, )
Details
Attachments
(1 file)
|
(deleted),
patch
|
fherrera
:
review+
MarcoZ
:
review+
davidb
:
review+
davidb
:
approval2.0+
|
Details | Diff | Splinter Review |
The role nothing should be transparent for name calculation recursion, it's just container that we nothing about it. It should be similar to text containers like paragraphs in this case - just look inside.
The affect of eNoRule for role nothing can be seen on dojo dropdown button menus, where NVDA does announce only group information of menuitem when you traverse through menuitems.
|
Assignee | |
Comment 1•14 years ago
|
||
Assignee: nobody → surkov.alexander
Attachment #491455 -
Flags: review?(marco.zehe)
Attachment #491455 -
Flags: review?(fherrera)
Attachment #491455 -
Flags: approval2.0?
|
||
Comment 2•14 years ago
|
||
Same with orca. Without the patach it only speaks "menuitem" while traversing items and with the patch it speaks "menuitem 1" and "menuitem 2"
|
||
Comment 3•14 years ago
|
||
Comment on attachment 491455 [details] [diff] [review]
patch
[r=me] I'll wait for reviewers before approval (I didn't check the tests).
> PRUint32 nsTextEquivUtils::gRoleToNameRulesMap[] =
> {
>- eNoRule, // ROLE_NOTHING
>+ eFromSubtreeIfRec, // ROLE_NOTHING
Seems right, since we can't assume ROLE_NOTHING is a dead end while recursing for a name.
Attachment #491455 -
Flags: review+
|
||
Comment 4•14 years ago
|
||
Comment on attachment 491455 [details] [diff] [review]
patch
r=me. Thanks also for reorganizing them into the separate folder!
Attachment #491455 -
Flags: review?(marco.zehe) → review+
|
|
||
Comment 5•14 years ago
|
||
Comment on attachment 491455 [details] [diff] [review]
patch
Approved.
Attachment #491455 -
Flags: approval2.0? → approval2.0+
|
|
||
Comment 6•14 years ago
|
||
Comment on attachment 491455 [details] [diff] [review]
patch
r=me
sorry for been late here :)
Attachment #491455 -
Flags: review?(fherrera) → review+
|
|
Assignee | |
Comment 7•14 years ago
|
||
landed on 2.0 - http://hg.mozilla.org/mozilla-central/rev/a54bdb8efa9d
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
You need to log in
before you can comment on or make changes to this bug.
Description
•