Justin Dolske [:Dolske] Assignee
	Description • 14 years ago

Bug 59314 is adding support for tab-modal prompts. 2 tests currently interact with prompts by listening for |domwindowopened| notifications. Since tab-modal prompts don't open windows, these tests break.

I've converted these two tests to use the notifications fired by nsIPrompts (common-dialog-loaded and tabmodal-dialog-loaded). They will work with current trunk (pre-59314), as well as once bug 59314 lands.

[Currently pushing this to try.]

	(no longer active)
	Comment 1 • 14 years ago

Comment on attachment 491737 [details] [diff] [review]
Patch v.1

r=me on the editor test, as long as you get a green run on try.

	Justin Dolske [:Dolske] Assignee
	Comment 2 • 14 years ago

Try run was green. Since the other test change (browser_sidebarpanels_click.js) change is fairly trivial, will land this shortly.

	Justin Dolske [:Dolske] Assignee
	Comment 3 • 14 years ago

Pushed http://hg.mozilla.org/mozilla-central/rev/bbc4273845eb