Switch to using tab-modal prompt dialogs for HTTP authentication
Categories
(Toolkit :: General, defect, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox82 | --- | fixed |
People
(Reporter: ehsan.akhgari, Assigned: pbz)
References
(Depends on 2 open bugs, Blocks 5 open bugs, )
Details
(Whiteboard: [qx:spec])
Attachments
(4 files)
Comment 3•14 years ago
|
||
Reporter | ||
Comment 4•14 years ago
|
||
Comment 5•14 years ago
|
||
Comment 6•14 years ago
|
||
Comment 7•14 years ago
|
||
Updated•12 years ago
|
Comment 13•12 years ago
|
||
Comment 14•12 years ago
|
||
Comment 15•12 years ago
|
||
Comment 16•12 years ago
|
||
Comment 17•12 years ago
|
||
Comment 18•12 years ago
|
||
Comment 19•12 years ago
|
||
Comment 20•12 years ago
|
||
Comment 21•12 years ago
|
||
Comment 22•12 years ago
|
||
Comment 24•11 years ago
|
||
Updated•11 years ago
|
Updated•11 years ago
|
Updated•11 years ago
|
Updated•11 years ago
|
Updated•11 years ago
|
Updated•11 years ago
|
Updated•11 years ago
|
Updated•11 years ago
|
Comment 29•11 years ago
|
||
Updated•11 years ago
|
Comment 30•11 years ago
|
||
Comment 31•11 years ago
|
||
Updated•11 years ago
|
Updated•11 years ago
|
Reporter | ||
Comment 33•11 years ago
|
||
Comment 34•11 years ago
|
||
Updated•11 years ago
|
Updated•11 years ago
|
Updated•11 years ago
|
Updated•11 years ago
|
Comment hidden (off-topic) |
Updated•10 years ago
|
Comment 36•10 years ago
|
||
Updated•10 years ago
|
Comment 37•10 years ago
|
||
Comment 38•10 years ago
|
||
Updated•10 years ago
|
Comment 40•10 years ago
|
||
Updated•9 years ago
|
Comment 41•9 years ago
|
||
Comment 42•9 years ago
|
||
Updated•8 years ago
|
Comment 44•8 years ago
|
||
Updated•7 years ago
|
Updated•7 years ago
|
Comment 48•7 years ago
|
||
Comment hidden (advocacy) |
Updated•7 years ago
|
Comment 55•7 years ago
|
||
Comment 56•7 years ago
|
||
Comment 57•7 years ago
|
||
Comment 58•7 years ago
|
||
Updated•6 years ago
|
Comment hidden (advocacy) |
Updated•6 years ago
|
Comment 67•6 years ago
|
||
We can probably use an approach similar to the Web Payments dialog which was still connected to the .browserContainer but also overlapped the chrome using absolute positioning (via a hack using HTML since XUL doesn't support abs. pos.). I think we could move all <tabmodalprompt> inside an <html:div> like .paymentDialogContainer and then have CSS trigger the position:absolute depending on which prompt is top-most since I assume we don't want regular alert()/confirm() to overlap chrome, only http-auth.
Updated•5 years ago
|
Comment hidden (advocacy) |
Comment hidden (advocacy) |
Comment 72•5 years ago
|
||
As the design from bug 977037 is already somewhat dated by now, should it be reopened to adjust the UI?
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 74•5 years ago
|
||
Depends on D75566
Assignee | ||
Comment 75•5 years ago
|
||
Depends on D75567
Updated•5 years ago
|
Comment 76•4 years ago
|
||
Assignee | ||
Comment 77•4 years ago
|
||
This got backed out along with Bug 1633370. I'm currently working on the new UX for tab chrome prompts. It's probably better to re-land this once the new UI is done.
Comment 78•4 years ago
|
||
Updated•4 years ago
|
Comment 79•4 years ago
|
||
Comment 80•4 years ago
|
||
Backed out 3 changesets (bug 1633370, bug 613785) for test_alert_opened_before_session_starts failures.
Backout link: https://hg.mozilla.org/integration/autoland/rev/a82361f4787aaf24b3814249e756d08c80fb2686
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=315152856&repo=autoland&lineNumber=39118
[task 2020-09-08T23:56:34.959Z] 23:56:34 INFO - TEST-START | testing/marionette/harness/marionette_harness/tests/unit/test_modal_dialogs.py TestModalAlerts.test_alert_opened_before_session_starts
[task 2020-09-08T23:56:34.963Z] 23:56:34 INFO - 1599609394958 Marionette DEBUG Closed connection 9
[task 2020-09-08T23:56:34.963Z] 23:56:34 INFO - 1599609394959 Marionette DEBUG Accepted connection 10 from 127.0.0.1:58306
[task 2020-09-08T23:56:34.964Z] 23:56:34 INFO - 1599609394960 Marionette DEBUG 10 -> [0,1,"WebDriver:NewSession",{"strictFileInteractability":true}]
[task 2020-09-08T23:56:34.964Z] 23:56:34 INFO - 1599609394961 Marionette TRACE [15] Frame script loaded
[task 2020-09-08T23:56:34.964Z] 23:56:34 INFO - 1599609394961 Marionette TRACE [15] Frame script registered
[task 2020-09-08T23:56:34.965Z] 23:56:34 INFO - 1599609394962 Marionette DEBUG 10 <- [1,1,null,{"sessionId":"e2b792a8-6746-4ed6-aa27-9d2f7c7b19d8","capabilities":{"browserName":"firefox","browserVersion":"82.0a ... mp/tmpiKgglC.mozrunner","moz:shutdownTimeout":60000,"moz:useNonSpecCompliantPointerOrigin":false,"moz:webdriverClick":true}}]
[task 2020-09-08T23:56:34.967Z] 23:56:34 INFO - 1599609394965 Marionette DEBUG 10 -> [0,2,"WebDriver:SetTimeouts",{"script":30000}]
[task 2020-09-08T23:56:34.967Z] 23:56:34 INFO - 1599609394965 Marionette DEBUG 10 <- [1,2,null,{"value":null}]
[task 2020-09-08T23:56:34.967Z] 23:56:34 INFO - 1599609394966 Marionette DEBUG 10 -> [0,3,"WebDriver:SetTimeouts",{"pageLoad":300000}]
[task 2020-09-08T23:56:34.968Z] 23:56:34 INFO - 1599609394966 Marionette DEBUG 10 <- [1,3,null,{"value":null}]
[task 2020-09-08T23:56:34.972Z] 23:56:34 INFO - 1599609394968 Marionette DEBUG 10 -> [0,4,"WebDriver:SetTimeouts",{"implicit":0}]
[task 2020-09-08T23:56:34.972Z] 23:56:34 INFO - 1599609394968 Marionette DEBUG 10 <- [1,4,null,{"value":null}]
[task 2020-09-08T23:56:34.973Z] 23:56:34 INFO - 1599609394969 Marionette DEBUG 10 -> [0,5,"WebDriver:GetChromeWindowHandle",{}]
[task 2020-09-08T23:56:34.973Z] 23:56:34 INFO - 1599609394969 Marionette DEBUG 10 <- [1,5,null,{"value":"1"}]
[task 2020-09-08T23:56:34.973Z] 23:56:34 INFO - 1599609394970 Marionette DEBUG 10 -> [0,6,"WebDriver:GetChromeWindowHandles",{}]
[task 2020-09-08T23:56:34.973Z] 23:56:34 INFO - 1599609394970 Marionette DEBUG 10 <- [1,6,null,["1"]]
[task 2020-09-08T23:56:34.973Z] 23:56:34 INFO - 1599609394970 Marionette DEBUG 10 -> [0,7,"WebDriver:GetWindowHandle",{}]
[task 2020-09-08T23:56:34.974Z] 23:56:34 INFO - 1599609394970 Marionette DEBUG 10 <- [1,7,null,{"value":"15"}]
[task 2020-09-08T23:56:34.976Z] 23:56:34 INFO - 1599609394971 Marionette DEBUG 10 -> [0,8,"WebDriver:GetWindowHandles",{}]
[task 2020-09-08T23:56:34.976Z] 23:56:34 INFO - 1599609394972 Marionette DEBUG 10 <- [1,8,null,["15"]]
[task 2020-09-08T23:56:34.977Z] 23:56:34 INFO - 1599609394974 Marionette DEBUG 10 -> [0,9,"WebDriver:GetWindowHandles",{}]
[task 2020-09-08T23:56:34.977Z] 23:56:34 INFO - 1599609394975 Marionette DEBUG 10 <- [1,9,null,["15"]]
[task 2020-09-08T23:56:34.978Z] 23:56:34 INFO - 1599609394975 Marionette DEBUG 10 -> [0,10,"WebDriver:NewWindow",{"type":"tab","focus":false,"private":false}]
[task 2020-09-08T23:56:34.994Z] 23:56:34 INFO - 1599609394983 Marionette TRACE Received DOM event TabOpen for [object XULElement]
[task 2020-09-08T23:56:35.034Z] 23:56:35 INFO - DEBUG: Adding blocker ContentParent: id=7fb88b0af000 for phase xpcom-will-shutdown
[task 2020-09-08T23:56:35.034Z] 23:56:35 INFO - DEBUG: Adding blocker ContentParent: id=7fb88b0af000 for phase profile-before-change
[task 2020-09-08T23:56:35.076Z] 23:56:35 INFO - 1599609395070 Marionette TRACE [34] Frame script loaded
[task 2020-09-08T23:56:35.076Z] 23:56:35 INFO - 1599609395072 Marionette TRACE [34] Frame script registered
[task 2020-09-08T23:56:35.104Z] 23:56:35 INFO - 1599609395098 Marionette DEBUG 10 <- [1,10,null,{"handle":"34","type":"tab"}]
[task 2020-09-08T23:56:35.120Z] 23:56:35 INFO - 1599609395115 Marionette DEBUG 10 -> [0,11,"WebDriver:GetWindowHandles",{}]
[task 2020-09-08T23:56:35.120Z] 23:56:35 INFO - 1599609395115 Marionette DEBUG 10 <- [1,11,null,["15","34"]]
[task 2020-09-08T23:56:35.120Z] 23:56:35 INFO - 1599609395116 Marionette DEBUG 10 -> [0,12,"WebDriver:GetWindowHandles",{}]
[task 2020-09-08T23:56:35.120Z] 23:56:35 INFO - 1599609395116 Marionette DEBUG 10 <- [1,12,null,["15","34"]]
[task 2020-09-08T23:56:35.140Z] 23:56:35 INFO - 1599609395135 Marionette DEBUG 10 -> [0,13,"WebDriver:SwitchToWindow",{"handle":"34","focus":true}]
[task 2020-09-08T23:56:35.161Z] 23:56:35 INFO - 1599609395158 Marionette TRACE Received DOM event TabSelect for [object XULElement]
[task 2020-09-08T23:56:35.177Z] 23:56:35 INFO - 1599609395168 Marionette DEBUG 10 <- [1,13,null,{"value":null}]
[task 2020-09-08T23:56:35.177Z] 23:56:35 INFO - 1599609395171 Marionette DEBUG 10 -> [0,14,"Marionette:GetContext",{}]
[task 2020-09-08T23:56:35.177Z] 23:56:35 INFO - 1599609395171 Marionette DEBUG 10 <- [1,14,null,{"value":"content"}]
[task 2020-09-08T23:56:35.177Z] 23:56:35 INFO - 1599609395173 Marionette DEBUG 10 -> [0,15,"Marionette:SetContext",{"value":"chrome"}]
[task 2020-09-08T23:56:35.177Z] 23:56:35 INFO - 1599609395174 Marionette DEBUG 10 <- [1,15,null,{"value":null}]
[task 2020-09-08T23:56:35.177Z] 23:56:35 INFO - 1599609395175 Marionette DEBUG 10 -> [0,16,"WebDriver:ExecuteScript",{"script":"Components.utils.import(\"resource://gre/modules/Preferences.jsm\");\n\n ... e,false],"filename":"../../venv/lib/python2.7/site-packages/marionette_driver/marionette.py","sandbox":"default","line":770}]
[task 2020-09-08T23:56:35.180Z] 23:56:35 INFO - 1599609395179 Marionette DEBUG 10 <- [1,16,null,{"value":null}]
[task 2020-09-08T23:56:35.182Z] 23:56:35 INFO - 1599609395179 Marionette DEBUG 10 -> [0,17,"Marionette:SetContext",{"value":"content"}]
[task 2020-09-08T23:56:35.182Z] 23:56:35 INFO - 1599609395180 Marionette DEBUG 10 <- [1,17,null,{"value":null}]
[task 2020-09-08T23:56:35.183Z] 23:56:35 INFO - 1599609395180 Marionette DEBUG 10 -> [0,18,"WebDriver:Navigate",{"url":"http://127.0.0.1:34551/http_auth"}]
[task 2020-09-08T23:56:35.186Z] 23:56:35 INFO - 1599609395184 Marionette TRACE Using browsing context 34
[task 2020-09-08T23:56:35.201Z] 23:56:35 INFO - 1599609395193 Marionette TRACE [34] Received DOM event beforeunload for about:blank
[task 2020-09-08T23:56:35.310Z] 23:56:35 INFO - 1599609395307 Marionette TRACE Received observer notification common-dialog-loaded
[task 2020-09-08T23:56:35.311Z] 23:56:35 INFO - 1599609395308 Marionette DEBUG 10 <- [1,18,null,{"value":null}]
[task 2020-09-08T23:56:35.320Z] 23:56:35 INFO - 1599609395315 Marionette DEBUG 10 -> [0,19,"WebDriver:GetTimeouts",{}]
[task 2020-09-08T23:56:35.320Z] 23:56:35 INFO - 1599609395315 Marionette DEBUG 10 <- [1,19,null,{"implicit":0,"pageLoad":300000,"script":30000}]
[task 2020-09-08T23:56:35.320Z] 23:56:35 INFO - 1599609395316 Marionette DEBUG 10 -> [0,20,"WebDriver:GetAlertText",{}]
[task 2020-09-08T23:56:35.320Z] 23:56:35 INFO - 1599609395316 Marionette DEBUG 10 <- [1,20,null,{"value":"http://127.0.0.1:34551 is requesting your username and password. The site says: “secret”"}]
[task 2020-09-08T23:56:35.320Z] 23:56:35 INFO - 1599609395316 Marionette DEBUG 10 -> [0,21,"WebDriver:DeleteSession",{}]
[task 2020-09-08T23:56:35.321Z] 23:56:35 INFO - 1599609395319 Marionette DEBUG 10 <- [1,21,null,{"value":null}]
[task 2020-09-08T23:56:35.329Z] 23:56:35 INFO - 1599609395324 Marionette DEBUG Closed connection 10
[task 2020-09-08T23:56:35.330Z] 23:56:35 INFO - 1599609395326 Marionette DEBUG Accepted connection 11 from 127.0.0.1:58310
[task 2020-09-08T23:56:35.332Z] 23:56:35 INFO - 1599609395328 Marionette DEBUG 11 -> [0,1,"WebDriver:NewSession",{"strictFileInteractability":true}]
[task 2020-09-08T23:56:35.334Z] 23:56:35 INFO - 1599609395331 Marionette TRACE [15] Frame script loaded
[task 2020-09-08T23:56:35.334Z] 23:56:35 INFO - 1599609395331 Marionette TRACE [34] Frame script loaded
[task 2020-09-08T23:56:35.334Z] 23:56:35 INFO - 1599609395332 Marionette TRACE [15] Frame script registered
[task 2020-09-08T23:56:35.334Z] 23:56:35 INFO - 1599609395332 Marionette TRACE [34] Frame script registered
[task 2020-09-08T23:56:35.338Z] 23:56:35 INFO - 1599609395335 Marionette DEBUG 11 <- [1,1,null,{"sessionId":"3c981ab5-977b-4b94-ab28-8aface957fe9","capabilities":{"browserName":"firefox","browserVersion":"82.0a ... mp/tmpiKgglC.mozrunner","moz:shutdownTimeout":60000,"moz:useNonSpecCompliantPointerOrigin":false,"moz:webdriverClick":true}}]
[task 2020-09-08T23:56:35.338Z] 23:56:35 INFO - 1599609395336 Marionette DEBUG 11 -> [0,2,"WebDriver:DismissAlert",{}]
[task 2020-09-08T23:56:35.340Z] 23:56:35 INFO - 1599609395336 Marionette DEBUG 11 <- [1,2,{"error":"no such alert","message":"","stacktrace":"WebDriverError@chrome://marionette/content/error.js:175:5\nNoSuchAle ... e://gre/modules/LoginManagerAuthPrompter.jsm:760:30\nrun@resource://gre/modules/LoginManagerAuthPrompter.jsm:187:27\n"},null]
[task 2020-09-08T23:56:35.341Z] 23:56:35 INFO - 1599609395339 Marionette DEBUG 11 -> [0,3,"Marionette:GetContext",{}]
[task 2020-09-08T23:56:35.344Z] 23:56:35 INFO - 1599609395339 Marionette DEBUG 11 <- [1,3,null,{"value":"content"}]
[task 2020-09-08T23:56:35.345Z] 23:56:35 INFO - 1599609395341 Marionette DEBUG 11 -> [0,4,"Marionette:SetContext",{"value":"chrome"}]
[task 2020-09-08T23:56:35.345Z] 23:56:35 INFO - 1599609395341 Marionette DEBUG 11 <- [1,4,null,{"value":null}]
[task 2020-09-08T23:56:35.347Z] 23:56:35 INFO - 1599609395343 Marionette DEBUG 11 -> [0,5,"WebDriver:TakeScreenshot",{"full":true,"hash":false,"id":null,"scroll":true}]
[task 2020-09-08T23:56:35.348Z] 23:56:35 INFO - 1599609395343 Marionette TRACE Using browsing context 1
[task 2020-09-08T23:56:35.425Z] 23:56:35 INFO - TEST-UNEXPECTED-ERROR | testing/marionette/harness/marionette_harness/tests/unit/test_modal_dialogs.py TestModalAlerts.test_alert_opened_before_session_starts | NoAlertPresentException:
[task 2020-09-08T23:56:35.426Z] 23:56:35 INFO - stacktrace:
[task 2020-09-08T23:56:35.426Z] 23:56:35 INFO - WebDriverError@chrome://marionette/content/error.js:175:5
[task 2020-09-08T23:56:35.427Z] 23:56:35 INFO - NoSuchAlertError@chrome://marionette/content/error.js:376:5
[task 2020-09-08T23:56:35.427Z] 23:56:35 INFO - GeckoDriver.prototype._checkIfAlertIsPresent@chrome://marionette/content/driver.js:3381:11
[task 2020-09-08T23:56:35.427Z] 23:56:35 INFO - GeckoDriver.prototype.dismissDialog@chrome://marionette/content/driver.js:3294:8
[task 2020-09-08T23:56:35.427Z] 23:56:35 INFO - despatch@chrome://marionette/content/server.js:303:40
[task 2020-09-08T23:56:35.427Z] 23:56:35 INFO - execute@chrome://marionette/content/server.js:273:16
[task 2020-09-08T23:56:35.427Z] 23:56:35 INFO - onPacket/<@chrome://marionette/content/server.js:246:20
[task 2020-09-08T23:56:35.427Z] 23:56:35 INFO - onPacket@chrome://marionette/content/server.js:247:9
[task 2020-09-08T23:56:35.427Z] 23:56:35 INFO - _onJSONObjectReady/<@chrome://marionette/content/transport.js:501:20
[task 2020-09-08T23:56:35.427Z] 23:56:35 INFO - openPromptSync@resource://gre/modules/Prompter.jsm:1081:17
[task 2020-09-08T23:56:35.427Z] 23:56:35 INFO - nsIPrompt_promptUsernameAndPassword@resource://gre/modules/Prompter.jsm:1521:10
[task 2020-09-08T23:56:35.427Z] 23:56:35 INFO - promptAuth@resource://gre/modules/Prompter.jsm:1664:17
[task 2020-09-08T23:56:35.428Z] 23:56:35 INFO - promptAuthBC@resource://gre/modules/Prompter.jsm:689:14
[task 2020-09-08T23:56:35.428Z] 23:56:35 INFO - promptAuth@resource://gre/modules/LoginManagerAuthPrompter.jsm:760:30
[task 2020-09-08T23:56:35.428Z] 23:56:35 INFO - run@resource://gre/modules/LoginManagerAuthPrompter.jsm:187:27
[task 2020-09-08T23:56:35.428Z] 23:56:35 INFO - Traceback (most recent call last):
[task 2020-09-08T23:56:35.429Z] 23:56:35 INFO - File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/marionette_harness/marionette_test/testcases.py", line 196, in run
[task 2020-09-08T23:56:35.429Z] 23:56:35 INFO - testMethod()
[task 2020-09-08T23:56:35.429Z] 23:56:35 INFO - File "/builds/worker/workspace/build/tests/marionette/tests/testing/marionette/harness/marionette_harness/tests/unit/test_modal_dialogs.py", line 206, in test_alert_opened_before_session_starts
[task 2020-09-08T23:56:35.429Z] 23:56:35 INFO - alert.dismiss()
[task 2020-09-08T23:56:35.429Z] 23:56:35 INFO - File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/marionette_driver/marionette.py", line 378, in dismiss
[task 2020-09-08T23:56:35.429Z] 23:56:35 INFO - self.marionette._send_message("WebDriver:DismissAlert")
[task 2020-09-08T23:56:35.429Z] 23:56:35 INFO - File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/marionette_driver/decorators.py", line 26, in _
[task 2020-09-08T23:56:35.429Z] 23:56:35 INFO - return func(*args, **kwargs)
[task 2020-09-08T23:56:35.429Z] 23:56:35 INFO - File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/marionette_driver/marionette.py", line 602, in _send_message
[task 2020-09-08T23:56:35.429Z] 23:56:35 INFO - self._handle_error(err)
[task 2020-09-08T23:56:35.430Z] 23:56:35 INFO - File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/marionette_driver/marionette.py", line 622, in _handle_error
[task 2020-09-08T23:56:35.430Z] 23:56:35 INFO - raise errors.lookup(error)(message, stacktrace=stacktrace)
[task 2020-09-08T23:56:35.430Z] 23:56:35 INFO - TEST-INFO took 441ms
[task 2020-09-08T23:56:35.430Z] 23:56:35 INFO - 1599609395392 Marionette DEBUG 11 <- [1,5,null,{"value":"iVBORw0KGgoAAAANSUhEUgAABQAAAAQQCAYAAAC9RfbYAAAgAElEQVR4nOzd23OU953g//kDMv/KXm3t1e9yrnzjcmV+VZlMNqlKJvEmt ... AjAAIAAFA2awcgQJkACAAAQJkACOyeAAgAAECZAAjsngAIAABAmQAI7J4ACAAAQJkACOyeAAgAAECZAAjsngAIAABA2QdjdW0fo0V/uwAAAABJRU5ErkJggg=="}]
[task 2020-09-08T23:56:35.430Z] 23:56:35 INFO - 1599609395394 Marionette DEBUG 11 -> [0,6,"Marionette:SetContext",{"value":"content"}]
[task 2020-09-08T23:56:35.430Z] 23:56:35 INFO - 1599609395394 Marionette DEBUG 11 <- [1,6,null,{"value":null}]
[task 2020-09-08T23:56:35.431Z] 23:56:35 INFO - 1599609395394 Marionette DEBUG 11 -> [0,7,"Marionette:GetContext",{}]
[task 2020-09-08T23:56:35.431Z] 23:56:35 INFO - 1599609395394 Marionette DEBUG 11 <- [1,7,null,{"value":"content"}]
[task 2020-09-08T23:56:35.432Z] 23:56:35 INFO - 1599609395395 Marionette DEBUG 11 -> [0,8,"Marionette:SetContext",{"value":"content"}]
[task 2020-09-08T23:56:35.432Z] 23:56:35 INFO - 1599609395395 Marionette DEBUG 11 <- [1,8,null,{"value":null}]
[task 2020-09-08T23:56:35.433Z] 23:56:35 INFO - 1599609395395 Marionette DEBUG 11 -> [0,9,"WebDriver:GetPageSource",{}]
[task 2020-09-08T23:56:35.433Z] 23:56:35 INFO - 1599609395397 Marionette DEBUG 11 <- [1,9,null,{"value":"<html><head></head><body></body></html>"}]
[task 2020-09-08T23:56:35.434Z] 23:56:35 INFO - 1599609395397 Marionette DEBUG 11 -> [0,10,"Marionette:SetContext",{"value":"content"}]
[task 2020-09-08T23:56:35.434Z] 23:56:35 INFO - 1599609395397 Marionette DEBUG 11 <- [1,10,null,{"value":null}]
[task 2020-09-08T23:56:35.435Z] 23:56:35 INFO - 1599609395405 Marionette DEBUG 11 -> [0,11,"Marionette:GetContext",{}]
[task 2020-09-08T23:56:35.435Z] 23:56:35 INFO - 1599609395405 Marionette DEBUG 11 <- [1,11,null,{"value":"content"}]
[task 2020-09-08T23:56:35.435Z] 23:56:35 INFO - 1599609395407 Marionette DEBUG 11 -> [0,12,"Marionette:SetContext",{"value":"chrome"}]
[task 2020-09-08T23:56:35.436Z] 23:56:35 INFO - 1599609395407 Marionette DEBUG 11 <- [1,12,null,{"value":null}]
[task 2020-09-08T23:56:35.436Z] 23:56:35 INFO - 1599609395408 Marionette DEBUG 11 -> [0,13,"WebDriver:ExecuteScript",{"script":"Components.utils.import(\"resource://gre/modules/Preferences.jsm\");\n ... -allow"],"filename":"../../venv/lib/python2.7/site-packages/marionette_driver/marionette.py","sandbox":"default","line":708}]
[task 2020-09-08T23:56:35.437Z] 23:56:35 INFO - 1599609395410 Marionette DEBUG 11 <- [1,13,null,{"value":null}]
[task 2020-09-08T23:56:35.437Z] 23:56:35 INFO - 1599609395411 Marionette DEBUG 11 -> [0,14,"Marionette:SetContext",{"value":"content"}]
[task 2020-09-08T23:56:35.438Z] 23:56:35 INFO - 1599609395411 Marionette DEBUG 11 <- [1,14,null,{"value":null}]
[task 2020-09-08T23:56:35.438Z] 23:56:35 INFO - 1599609395411 Marionette DEBUG 11 -> [0,15,"WebDriver:GetWindowHandles",{}]
[task 2020-09-08T23:56:35.439Z] 23:56:35 INFO - 1599609395412 Marionette DEBUG 11 <- [1,15,null,["15","34"]]
[task 2020-09-08T23:56:35.440Z] 23:56:35 INFO - 1599609395412 Marionette DEBUG 11 -> [0,16,"WebDriver:SwitchToWindow",{"handle":"34","focus":true}]
[task 2020-09-08T23:56:35.446Z] 23:56:35 INFO - 1599609395413 Marionette DEBUG 11 <- [1,16,null,{"value":null}]
[task 2020-09-08T23:56:35.450Z] 23:56:35 INFO - 1599609395413 Marionette DEBUG 11 -> [0,17,"WebDriver:CloseWindow",{}]
[task 2020-09-08T23:56:35.458Z] 23:56:35 INFO - 1599609395441 Marionette TRACE Received DOM event TabClose for [object XULElement]
[task 2020-09-08T23:56:35.463Z] 23:56:35 INFO - 1599609395459 Marionette TRACE Received observer notification message-manager-disconnect
[task 2020-09-08T23:56:35.465Z] 23:56:35 INFO - 1599609395459 Marionette DEBUG 11 <- [1,17,null,["15"]]
[task 2020-09-08T23:56:35.466Z] 23:56:35 INFO - JavaScript error: resource://gre/modules/Prompter.jsm, line 1189: NS_ERROR_NOT_AVAILABLE: prompt aborted by user
[task 2020-09-08T23:56:35.467Z] 23:56:35 INFO - 1599609395462 Marionette DEBUG 11 -> [0,18,"WebDriver:SwitchToWindow",{"handle":"15","focus":true}]
[task 2020-09-08T23:56:35.472Z] 23:56:35 INFO - 1599609395463 Marionette DEBUG 11 <- [1,18,null,{"value":null}]
[task 2020-09-08T23:56:35.473Z] 23:56:35 INFO - 1599609395463 Marionette DEBUG 11 -> [0,19,"WebDriver:GetChromeWindowHandles",{}]
[task 2020-09-08T23:56:35.474Z] 23:56:35 INFO - 1599609395463 Marionette DEBUG 11 <- [1,19,null,["1"]]
[task 2020-09-08T23:56:35.474Z] 23:56:35 INFO - 1599609395465 Marionette DEBUG 11 -> [0,20,"WebDriver:GetWindowHandles",{}]
[task 2020-09-08T23:56:35.475Z] 23:56:35 INFO - 1599609395466 Marionette DEBUG 11 <- [1,20,null,["15"]]
[task 2020-09-08T23:56:35.477Z] 23:56:35 INFO - 1599609395467 Marionette DEBUG 11 -> [0,21,"WebDriver:DeleteSession",{}]
[task 2020-09-08T23:56:35.478Z] 23:56:35 INFO - 1599609395471 Marionette DEBUG 11 <- [1,21,null,{"value":null}]
...
Assignee | ||
Comment 81•4 years ago
|
||
Depends on D75568
Assignee | ||
Updated•4 years ago
|
Comment 82•4 years ago
|
||
Comment 83•4 years ago
|
||
Comment 84•4 years ago
|
||
Sorry for the backout, relanding.
Comment 85•4 years ago
|
||
Comment 86•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7603440e6c36
https://hg.mozilla.org/mozilla-central/rev/3729a6bb6ab2
https://hg.mozilla.org/mozilla-central/rev/184b034f637d
Comment 87•4 years ago
|
||
Thanks for fixing this!
Does the fix also mean that the TLS client cert auth dialogs are also fixed, or will they need a similar fix? The bug for those is https://bugzilla.mozilla.org/show_bug.cgi?id=1401466
Comment 88•4 years ago
|
||
Also, it would be great to have a screenshot of what the new UI looks like attached to this bug.
Assignee | ||
Comment 89•4 years ago
|
||
(In reply to Paul Wise from comment #87)
Thanks for fixing this!
Does the fix also mean that the TLS client cert auth dialogs are also fixed, or will they need a similar fix? The bug for those is https://bugzilla.mozilla.org/show_bug.cgi?id=1401466
That's separate window code, but it should be possible to also show that in the TabDialogBox.
(In reply to Paul Wise from comment #88)
Also, it would be great to have a screenshot of what the new UI looks like attached to this bug.
You can see it in the latest Nightly when you open a site that requires basic auth. For example: https://jigsaw.w3.org/HTTP/Basic/
Assignee | ||
Updated•4 years ago
|
Comment 90•4 years ago
|
||
I verified the fix using latest Nightly 83.0a1 on Windows 10 x64, Ubuntu 18.04 x64 and macOS 10.13. The issue is not reproducing anymore.
However when I used Firefox 82.0b2 on Windows 10 x64 and Ubuntu 18.04 x64, the window-modal was displayed.
Assignee | ||
Comment 91•4 years ago
|
||
The auth tab prompts are currently only enabled for Nightly.
Comment 93•4 years ago
|
||
Hi all,
As a user of Nightly, I have noticed the new modal pop-up for HTTP authentication. While I do like the look and feel of the new prompt, I have run into a slight issue when using a password manager to auto-fill the username and password. The password manager utilizes the window's title to match the appropriate entry and previously the prompt had a window title of "Authentication Required". After this change, the title is simply "Firefox Nightly" which would still work, but is a bit ambiguous and might match more entries than intended.
My question is, I'm wondering if it's possible to set the tab's title to use the same one as the previous prompt? I'm sure this would help out a lot of others using password managers.
Comment 94•4 years ago
|
||
(In reply to Kuzma Fesenko from comment #93)
Hi all,
As a user of Nightly, I have noticed the new modal pop-up for HTTP authentication. While I do like the look and feel of the new prompt, I have run into a slight issue when using a password manager to auto-fill the username and password. The password manager utilizes the window's title to match the appropriate entry and previously the prompt had a window title of "Authentication Required". After this change, the title is simply "Firefox Nightly" which would still work, but is a bit ambiguous and might match more entries than intended.
My question is, I'm wondering if it's possible to set the tab's title to use the same one as the previous prompt? I'm sure this would help out a lot of others using password managers.
This is a valid suggestion, can you file a new bug, please?
Comment 95•4 years ago
|
||
(In reply to Kuzma Fesenko from comment #93)
Hi all,
As a user of Nightly, I have noticed the new modal pop-up for HTTP authentication. While I do like the look and feel of the new prompt, I have run into a slight issue when using a password manager to auto-fill the username and password. The password manager utilizes the window's title to match the appropriate entry and previously the prompt had a window title of "Authentication Required". After this change, the title is simply "Firefox Nightly" which would still work, but is a bit ambiguous and might match more entries than intended.
My question is, I'm wondering if it's possible to set the tab's title to use the same one as the previous prompt? I'm sure this would help out a lot of others using password managers.
(In reply to Johann Hofmann [:johannh] from comment #94)
(In reply to Kuzma Fesenko from comment #93)
Hi all,
As a user of Nightly, I have noticed the new modal pop-up for HTTP authentication. While I do like the look and feel of the new prompt, I have run into a slight issue when using a password manager to auto-fill the username and password. The password manager utilizes the window's title to match the appropriate entry and previously the prompt had a window title of "Authentication Required". After this change, the title is simply "Firefox Nightly" which would still work, but is a bit ambiguous and might match more entries than intended.
My question is, I'm wondering if it's possible to set the tab's title to use the same one as the previous prompt? I'm sure this would help out a lot of others using password managers.
This is a valid suggestion, can you file a new bug, please?
Will do!
Comment 96•4 years ago
|
||
Hi, I believe this has made to Firefox 83, and my first thought when I saw the new prompt was that I was being spoofed. Had to do some hg repo archaeology to confirm that it indeed was a legitimate change and find the corresponding bugzilla issue..
Perhaps worth including in the changelog, so people aren't confused by the change? Thanks!
Assignee | ||
Updated•4 years ago
|
Description
•