Stefan Reporter
	Description • 14 years ago

User-Agent:       
Build Identifier: 

The tab display is corrupt (incomplete) when entering TabCandy for the first time with an "App Tab" open.

Reproducible: Always

Steps to Reproduce:
1. Set Home Page to "http://www.mozilla.org/".
2. Close all unpinned/pinned tabs, quit FF, restart FF.
3. Create new (empty) tab.
4. "Pin" that new tab as "App Tab".
5. Enter TabCandy.
Actual Results:  
-> attachment

Expected Results:  
-> attachment

	Stefan Reporter
	Comment 3 • 14 years ago

Build:

Mozilla/5.0 (X11; Linux x86_64; rv:2.0b8pre) Gecko/20100101 Firefox/4.0b8pre
Built from http://hg.mozilla.org/mozilla-central/rev/74b4a2f97e23

	Stefan Reporter
	Comment 4 • 14 years ago

The first bad revision is:
changeset:   57654:ea41c727079b
user:        Sean Dunn <seanedunn@yahoo.com>
date:        Mon Oct 11 11:57:00 2010 -0700
summary:     Bug 588630 - "When invoking TabCandy/Panorama with many open blank tabs, Firefox hangs & then pops up "Unresponsive Script" dialog" [r=dietrich, a=blocking]

	juan becerra [:juanb]
	Comment 5 • 14 years ago

I'm not able to reproduce this problem as described. After following the steps in comment #0 I see something like the expected results. See attachment.

	Stefan Reporter
	Comment 6 • 14 years ago

@juan: Which OS/FF Version did you use?

	Stefan Reporter
	Comment 7 • 14 years ago

Could reproduce the problem with

2010-11-22-03-mozilla-central
Mozilla/5.0 (X11; Linux i686; rv:2.0b8pre) Gecko/20101122 Firefox/4.0b8pre
Built from http://hg.mozilla.org/mozilla-central/rev/4d73807bfec7

	juan becerra [:juanb]
	Comment 8 • 14 years ago

Stefan, I used a Linux 64bit machine and the latest nighly with a clean profile. I also tried Mac OS 10.6.5. Did you try with a clean profile?

	Stefan Reporter
	Comment 9 • 14 years ago

Yes. Just verified it with a clean profile (screenshot "weird.jpg").

	juan becerra [:juanb]
	Comment 11 • 14 years ago

Ok, I tried this once again, and I am able to reproduce the problem, using the latest nightly 11/29 on Linux 64bit. I'm nominating for blocking, because it looks pretty ugly, although it's hard to tell how often users will encounter this scenario. Maybe it's a trivial fix.

	Paul O'Shannessy [:zpao] (not bugmail, email directly)
	Comment 13 • 14 years ago

Is this still happening?

	Stefan Reporter
	Comment 14 • 14 years ago

Yes
Mozilla/5.0 (X11; Linux x86_64; rv:2.0b9pre) Gecko/20100101 Firefox/4.0b9pre
http://hg.mozilla.org/mozilla-central/rev/8755d308796d

	David Dahl :ddahl Assignee
	Comment 15 • 14 years ago

So the appTab is represented by the tiny favicon, which when clicked on opens the app tab. will start digging into this.

	Kevin Hanes
	Comment 17 • 14 years ago

bugspam (moving b9 to b10)

	Kevin Hanes
	Comment 18 • 14 years ago

bugspam (removing b9)

	Ian Gilman [:iangilman]
	Comment 19 • 14 years ago

(In reply to comment #15)
> So the appTab is represented by the tiny favicon, which when clicked on opens
> the app tab. will start digging into this.

David, are you working on a fix for this?

	David Dahl :ddahl Assignee
	Comment 20 • 14 years ago

(In reply to comment #19)
> (In reply to comment #15)
> > So the appTab is represented by the tiny favicon, which when clicked on opens
> > the app tab. will start digging into this.
> 
> David, are you working on a fix for this?

I started, but changed focus to hardblockers. This is what I was planning on moving back to asap.

	David Dahl :ddahl Assignee
	Comment 21 • 14 years ago

I have been working on this today, tracing the code paths and the difference between how appTabs are handled vs. normal tabs... anyway, in my latest tests cannot reproduce this on 64bit linux and today's nightly with a clean profile.

I a updating my build and will test that as well. Can anyone else reproduce with the 2010-01-14 nightly?

	Stefan Reporter
	Comment 22 • 14 years ago

Mozilla/5.0 (X11; Linux x86_64; rv:2.0b10pre) Gecko/20110114 Firefox/4.0b10pre
reproduces an error. Screenshot follows.

	David Dahl :ddahl Assignee
	Comment 24 • 14 years ago

So, I had the appTab saved in the sessionStore - in which case - you do not see the bug at all. if you create the appTab after starting the browser, you see this bug.

	David Dahl :ddahl Assignee
	Comment 25 • 14 years ago

Another clue in DOM Inspector: http://img406.imageshack.us/img406/8320/minefieldgroupyourtabsd.png

look at the css object. there must be a programmatic setting of the tab height and width, making it 20 px by 30 px.

	Michael Yoshitaka Erlewine [:mitcho]
	Comment 26 • 14 years ago

softblocker = critical

	David Dahl :ddahl Assignee
	Comment 27 • 14 years ago

After today's hg pull I see the correct sized previews, but the previews cut off at the screen height:

http://img717.imageshack.us/img717/373/minefieldgroupyourtabs0.png

And, after navigating elsewhere, you end up with an overlay problem:

http://img153.imageshack.us/img153/373/minefieldgroupyourtabs0.png

	David Dahl :ddahl Assignee
	Comment 28 • 14 years ago

(In reply to comment #27)
> After today's hg pull I see the correct sized previews, but the previews cut
> off at the screen height:
> 
> http://img717.imageshack.us/img717/373/minefieldgroupyourtabs0.png
> 
> And, after navigating elsewhere, you end up with an overlay problem:
> 
> http://img153.imageshack.us/img153/373/minefieldgroupyourtabs0.png

also, this is apparently affecting all platforms.

	David Dahl :ddahl Assignee
	Comment 29 • 14 years ago

OK, so I think the patch in bug 606824 fixed this bug - if it was primarily a width/height issue.

I just did:
hg update -r d6eac3f4a14a

Which updates us to the state I was in when I last worked on this bug and sure enough, we have some corruption as far as height and width:

http://img819.imageshack.us/img819/373/minefieldgroupyourtabs0.png

	Ian Gilman [:iangilman]
	Comment 30 • 14 years ago

(In reply to comment #29)
> OK, so I think the patch in bug 606824 fixed this bug - if it was primarily a
> width/height issue.

So should we resolve this bug?

	Stefan Reporter
	Comment 31 • 14 years ago

Yes. Issue is absent in fe04d3537b36.

	David Dahl :ddahl Assignee
	Comment 32 • 14 years ago

Best guess is that this was fixed by bug 606824