Closed
Bug 614145
Opened 14 years ago
Closed 14 years ago
Fast-path null return values in quickstubs
Categories
(Core :: XPConnect, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla5
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
(Keywords: perf)
Attachments
(1 file)
|
(deleted),
patch
|
peterv
:
review+
bzbarsky
:
approval2.0-
|
Details | Diff | Splinter Review |
We're doing it in domclassinfo; no reason not to do it here too. Would avoid some expensive calls!
|
Assignee | |
Comment 1•14 years ago
|
||
|
|
Assignee | |
Comment 2•14 years ago
|
||
Applies on top of bug 614138.
Depends on: 614138
Whiteboard: [need review]
|
|
Assignee | |
Updated•14 years ago
|
|
|
Assignee | |
Updated•14 years ago
|
Attachment #492555 -
Flags: review?(peterv)
|
||
Comment 3•14 years ago
|
||
Comment on attachment 492555 [details] [diff] [review]
Fast-path null in quickstub return values.
Hmm, ok. I thought null values were rare here but I guess it doesn't hurt too much for the (common) non-null case. (And we really should switch to %(name) formatting to avoid repeating the same arguments over and over :-))
Attachment #492555 -
Flags: review?(peterv) → review+
|
|
Assignee | |
Updated•14 years ago
|
Attachment #492555 -
Flags: approval2.0?
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [need review] → [need approval]
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [need approval] → [need gk2 ship]
|
|
Assignee | |
Updated•14 years ago
|
Attachment #492555 -
Flags: approval2.0? → approval2.0-
|
|
Assignee | |
Comment 4•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [need gk2 ship]
Target Milestone: --- → mozilla2.2
You need to log in
before you can comment on or make changes to this bug.
Description
•