Closed
Bug 614724
Opened 14 years ago
Closed 14 years ago
Quickstub createElementNS
Categories
(Core :: DOM: Core & HTML, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla2.0b8
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
peterv
:
review+
jst
:
approval2.0+
|
Details | Diff | Splinter Review |
People use this for SVG, say.
Assignee | ||
Comment 1•14 years ago
|
||
Assignee | ||
Updated•14 years ago
|
Assignee | ||
Updated•14 years ago
|
Attachment #493159 -
Flags: review?(peterv)
Updated•14 years ago
|
Attachment #493159 -
Flags: review?(peterv) → review+
Assignee | ||
Updated•14 years ago
|
Whiteboard: [need review] → [need approval]
Assignee | ||
Comment 2•14 years ago
|
||
Comment on attachment 493159 [details] [diff] [review]
Quickstub craeteElementNS.
Very simple safe change that speeds up some in-the-wild things using SVG.
Attachment #493159 -
Flags: approval2.0?
Updated•14 years ago
|
Attachment #493159 -
Flags: approval2.0? → approval2.0+
Assignee | ||
Updated•14 years ago
|
Whiteboard: [need approval] → [need landing]
Comment 3•14 years ago
|
||
Was landed and backed out:
http://hg.mozilla.org/mozilla-central/rev/d1fe7786e33b
http://hg.mozilla.org/mozilla-central/rev/2789b87e8cba
Assignee | ||
Comment 4•14 years ago
|
||
Ah, yes. I don't know why I never ran into that crash locally. I've pushed the original patch, then a followup for the crash fix (because I pushed the original before seeing comment 3).
Assignee | ||
Comment 5•14 years ago
|
||
Pushed:
http://hg.mozilla.org/mozilla-central/rev/fa8acee0abe8
and a followup to fix the crash:
http://hg.mozilla.org/mozilla-central/rev/0418174c8522
Status: NEW → RESOLVED
Closed: 14 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Whiteboard: [need landing]
Target Milestone: --- → mozilla2.0b8
Comment 6•14 years ago
|
||
Backed out the patch for being in the range of bug 615736
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Updated•14 years ago
|
Whiteboard: [need landing]
Assignee | ||
Comment 7•14 years ago
|
||
Pushed http://hg.mozilla.org/mozilla-central/rev/57aa15b3fce9
(includes the followup already). Tree is green.
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•14 years ago
|
Whiteboard: [need landing]
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•