Closed
Bug 615220
Opened 14 years ago
Closed 14 years ago
Don't fire focus event for current focused accessible when document gets focus
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla2.0b8
People
(Reporter: surkov, Assigned: surkov)
References
(Blocks 1 open bug)
Details
(Keywords: access)
Attachments
(1 file)
(deleted),
patch
|
davidb
:
review+
davidb
:
approval2.0+
|
Details | Diff | Splinter Review |
It was related with focus handling in dialogs where we get focus event for document and then for focused element. Nowdays this code makes us to fire a11y focus event for focused element twice. That's not necessary any more since we coalesce focus events from the same document and in other words we fire a11y focus event for focused element. I don't like current approach since it's timing related and may result in twiced a11y focus events what's not necessary.
Attachment #493685 -
Flags: review?(bolterbugz)
Attachment #493685 -
Flags: approval2.0?
Comment 1•14 years ago
|
||
I'd like our guru to take a try build for a spin here.
Assignee | ||
Comment 2•14 years ago
|
||
(In reply to comment #1)
> I'd like our guru to take a try build for a spin here.
This one contains all my latest patches:
http://ftp.mozilla.org/pub/mozilla.org/firefox/tryserver-builds/surkov.alexander@gmail.com-02c4399322f7
Comment 3•14 years ago
|
||
I just ran with this build, and cannot report anything wrong with it. It reports focus fine when switching from one app to another or when switching tabs. I also tested with both NVDA and JAWS to make sure.
Comment 4•14 years ago
|
||
Comment on attachment 493685 [details] [diff] [review]
patch
r+a=me conditional on Marco's second spin working out ok.
Attachment #493685 -
Flags: review?(bolterbugz)
Attachment #493685 -
Flags: review+
Attachment #493685 -
Flags: approval2.0?
Attachment #493685 -
Flags: approval2.0+
Comment 5•14 years ago
|
||
Nope, there's something wrong when you go to www.youtube.com and JAWS running. The browser freezes either immediately, or after you enter a search term and press ENTER. It doesn't appear to hang taskmanager-wise, but JAWS doesn't read anything any more, no keyboard commands work etc.
Assignee | ||
Comment 6•14 years ago
|
||
try server build against trunk - http://ftp.mozilla.org/pub/mozilla.org/firefox/tryserver-builds/surkov.alexander@gmail.com-25bba87ca3ce
Assignee | ||
Comment 7•14 years ago
|
||
Comment 8•14 years ago
|
||
This latest try-server build works fine with JAWS and Youtube as well. I cannot reproduce the problems I describe in comment #5 with this build. So whatever finetuning you did seems to have solved this problem.
Assignee | ||
Comment 9•14 years ago
|
||
landed on 2.0 - http://hg.mozilla.org/mozilla-central/rev/dfedd535f514
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
You need to log in
before you can comment on or make changes to this bug.
Description
•