Closed
Bug 615285
Opened 14 years ago
Closed 14 years ago
Bookmark sync: track ordering on folder
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
People
(Reporter: philikon, Assigned: philikon)
References
Details
(Whiteboard: [has patch][needs review mconnor])
Attachments
(1 file)
(deleted),
patch
|
mconnor
:
review+
|
Details | Diff | Splinter Review |
To make the switch to async APIs easier, we want to switch bookmark ordering from being tracked as a linked list to being tracked on the folder that they're contained in. See https://wiki.mozilla.org/Places/AsyncAPIsForSync#Predecessor for details.
Assignee | ||
Comment 2•14 years ago
|
||
On the Firefox side of things we're going to track the ordered list of GUIDs in an annotation on the folder. That way the async Places API won't have to give us this by default but we still avoid a lot of I/O on first sync.
I have documented the changes to the bookmark storage format on the wiki: https://wiki.mozilla.org/Labs/Weave/Developer/BrowserObjects
Updated•14 years ago
|
blocking2.0: ? → beta8+
Updated•14 years ago
|
tracking-fennec: --- → ?
Updated•14 years ago
|
Assignee: nobody → philipp
Assignee | ||
Comment 3•14 years ago
|
||
Attachment #495553 -
Flags: review?(mconnor)
Assignee | ||
Updated•14 years ago
|
Whiteboard: [has patch][needs review mconnor]
Comment 4•14 years ago
|
||
Comment on attachment 495553 [details] [diff] [review]
v1
>+ // Reorder children according to the GUID list. Gracefully deal
>+ // with missing items, e.g. locally deleted.
>+ let delta = 0;
>+ for (let idx = 0; idx < children.length; idx++) {
>+ let itemid = this.idForGUID(children[idx]);
>+ //
>+ if (itemid == -1) {
empty comment?
(have to have at least one nit)
Attachment #495553 -
Flags: review?(mconnor) → review+
Assignee | ||
Comment 5•14 years ago
|
||
Pushed with nit addressed
https://hg.mozilla.org/services/fx-sync/rev/0bd095142655
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•