Closed
Bug 615636
Opened 14 years ago
Closed 13 years ago
Labels badly aligned when editing versions and milestones in admin pages
Categories
(Bugzilla :: User Interface, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 4.2
People
(Reporter: LpSolit, Assigned: selsky)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
LpSolit
:
review+
|
Details | Diff | Splinter Review |
Due to bug 77193 and the addition of "Enable for Bugs", field labels are now badly aligned when editing versions and milestones in admin pages. Some are missing a align="right" to make them look correct (or a class, if we have one which does that). Only affects Bugzilla 4.1.
![]() |
Reporter | |
Updated•13 years ago
|
Whiteboard: [Good Intro Bug]
Assignee | ||
Comment 1•13 years ago
|
||
I used the "field_label" class and removed the hard-coded align/valign attributes. I also added missing label tags to the component editing page. Note that without this patch, the "Enabled For Bugs:" and "Bugs:" labels on the edit components page are left-aligned and non-bold.
![]() |
Reporter | |
Comment 2•13 years ago
|
||
Comment on attachment 556454 [details] [diff] [review] Fix field labels v1 >=== modified file 'template/en/default/admin/components/edit-common.html.tmpl' >+ <th class="field_label"><label for="component">Component:</label></th> > <td><input size="64" maxlength="64" name="component" > value="[%- comp.name FILTER html %]"></td> The "for" attribute of <label> elements must point to an existing id. As the <input> field has no id="component" attribute, this won't work. You have to add the id attribute too when missing. >=== modified file 'template/en/default/admin/components/edit.html.tmpl' >+ <th class="field_label"><label for="isactive">Enabled For [% terms.Bugs %]:</label></td> Mix of <th> </td>! >+ <th class="field_label">[% terms.Bugs %]:</td> Same here.
Attachment #556454 -
Flags: review?(gerv) → review-
Assignee | ||
Comment 3•13 years ago
|
||
Attachment #556454 -
Attachment is obsolete: true
Attachment #556527 -
Flags: review?(LpSolit)
![]() |
Reporter | |
Comment 4•13 years ago
|
||
Comment on attachment 556527 [details] [diff] [review] Fix field labels v2 This is great, thanks! r=LpSolit
Attachment #556527 -
Flags: review?(LpSolit) → review+
![]() |
Reporter | |
Updated•13 years ago
|
Flags: approval4.2+
Flags: approval+
Whiteboard: [Good Intro Bug]
![]() |
Reporter | |
Comment 5•13 years ago
|
||
I fixed bitrot in 4.2 myself (due to bug 661476): Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/ modified template/en/default/admin/components/edit-common.html.tmpl modified template/en/default/admin/components/edit.html.tmpl modified template/en/default/admin/milestones/edit.html.tmpl modified template/en/default/admin/versions/edit.html.tmpl Committed revision 7972. Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.2/ modified template/en/default/admin/components/edit-common.html.tmpl modified template/en/default/admin/components/edit.html.tmpl modified template/en/default/admin/milestones/edit.html.tmpl modified template/en/default/admin/versions/edit.html.tmpl Committed revision 7938.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•