Closed
Bug 615735
Opened 14 years ago
Closed 14 years ago
Clean up find bar close button CSS in the winstripe theme
Categories
(Toolkit :: Themes, defect)
Tracking
()
RESOLVED
FIXED
mozilla2.0b10
People
(Reporter: pcwalton, Assigned: pcwalton)
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
beltzner
:
approval2.0+
|
Details | Diff | Splinter Review |
Per Dão's comments in bug 601667 the CSS rules for the close button in the find bar in the winstripe theme should be cleaned up a bit.
|
||
Comment 2•14 years ago
|
||
Comment on attachment 494197 [details] [diff] [review]
Proposed patch.
> .findbar-closebutton {
>- border: 1px solid transparent;
>- padding: 2px !important;
>+ border: none;
>+ padding: 3px;
> list-style-image: url("chrome://global/skin/icons/close.png");
> -moz-appearance: none;
> -moz-image-region: rect(0, 16px, 16px, 0);
> }
>
> .findbar-closebutton > .toolbarbutton-icon {
>- -moz-margin-end: 0px !important;
>- -moz-padding-end: 2px !important;
>- -moz-padding-start: 2px !important;
>+ -moz-margin-end: 0px;
>+ padding: 0 2px;
> }
-moz-margin-end: 0px; is a no-op (i.e. should be dropped). padding: 0 2px; looks like it should be dropped in favor of padding: 3px 5px; on .findbar-closebutton. r=me with that. Thanks!
Attachment #494197 -
Flags: review?(dao) → review+
|
|
||
Updated•14 years ago
|
Component: General → Themes
Product: Firefox → Toolkit
QA Contact: general → themes
|
Assignee | |
Updated•14 years ago
|
Attachment #494197 -
Flags: approval2.0?
|
|
||
Comment 3•14 years ago
|
||
Comment on attachment 494197 [details] [diff] [review]
Proposed patch.
Patrick, please see comment 2.
Attachment #494197 -
Flags: approval2.0?
|
|
Assignee | |
Comment 4•14 years ago
|
||
Oops. Duh, sorry. New version attached.
Attachment #494197 -
Attachment is obsolete: true
Attachment #497082 -
Flags: approval2.0?
|
||
Comment 5•14 years ago
|
||
Comment on attachment 497082 [details] [diff] [review]
Proposed patch, version 2.
a=beltzner
Attachment #497082 -
Flags: approval2.0? → approval2.0+
|
|
||
Comment 6•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b10
You need to log in
before you can comment on or make changes to this bug.
Description
•